maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Fix two test-only leaks found by LSan. 

The result of getBufferForFile() must be freed.
(Should we change functions that expect the caller to assume ownership so
that they return unique_ptrs instead? Then the type system makes sure we get
this right.)

llvm-svn: 207074
This commit is contained in:
Nico Weber 2014-04-24 04:26:18 +00:00
parent 82098cb6df
commit 4fcf0c7b29
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
clang/unittests/Tooling/RefactoringTest.cpp
View File

@ -252,7 +252,9 @@ public:
// descriptor, which might not see the changes made. // descriptor, which might not see the changes made.
// FIXME: Figure out whether there is a way to get the SourceManger to // FIXME: Figure out whether there is a way to get the SourceManger to
// reopen the file. // reopen the file.
return Context.Files.getBufferForFile(Path, NULL)->getBuffer(); std::unique_ptr<const llvm::MemoryBuffer> FileBuffer(
Context.Files.getBufferForFile(Path, NULL));
return FileBuffer->getBuffer();
} }
llvm::StringMap<std::string> TemporaryFiles; llvm::StringMap<std::string> TemporaryFiles;

4
clang/unittests/Tooling/RewriterTestContext.h
View File

@ -102,7 +102,9 @@ class RewriterTestContext {
// descriptor, which might not see the changes made. // descriptor, which might not see the changes made.
// FIXME: Figure out whether there is a way to get the SourceManger to // FIXME: Figure out whether there is a way to get the SourceManger to
// reopen the file. // reopen the file.
return Files.getBufferForFile(Path, NULL)->getBuffer(); std::unique_ptr<const llvm::MemoryBuffer> FileBuffer(
Files.getBufferForFile(Path, NULL));
return FileBuffer->getBuffer();
} }
IntrusiveRefCntPtr<DiagnosticOptions> DiagOpts; IntrusiveRefCntPtr<DiagnosticOptions> DiagOpts;