diff --git a/clang/lib/CodeGen/SwiftCallingConv.cpp b/clang/lib/CodeGen/SwiftCallingConv.cpp index 2a12078e198a..7dc2a1d089da 100644 --- a/clang/lib/CodeGen/SwiftCallingConv.cpp +++ b/clang/lib/CodeGen/SwiftCallingConv.cpp @@ -742,22 +742,10 @@ void swiftcall::legalizeVectorType(CodeGenModule &CGM, CharUnits origVectorSize, bool swiftcall::shouldPassCXXRecordIndirectly(CodeGenModule &CGM, const CXXRecordDecl *record) { - // Following a recommendation from Richard Smith, pass a C++ type - // indirectly only if the destructor is non-trivial or *all* of the - // copy/move constructors are deleted or non-trivial. - - if (record->hasNonTrivialDestructor()) - return true; - - // It would be nice if this were summarized on the CXXRecordDecl. - for (auto ctor : record->ctors()) { - if (ctor->isCopyOrMoveConstructor() && !ctor->isDeleted() && - ctor->isTrivial()) { - return false; - } - } - - return true; + // FIXME: should we not rely on the standard computation in Sema, just in + // case we want to diverge from the platform ABI (e.g. on targets where + // that uses the MSVC rule)? + return !record->canPassInRegisters(); } static ABIArgInfo classifyExpandedType(SwiftAggLowering &lowering, diff --git a/clang/test/CodeGenCXX/arm-swiftcall.cpp b/clang/test/CodeGenCXX/arm-swiftcall.cpp index 5c932c77b1da..36a5afad4c62 100644 --- a/clang/test/CodeGenCXX/arm-swiftcall.cpp +++ b/clang/test/CodeGenCXX/arm-swiftcall.cpp @@ -113,3 +113,13 @@ TEST(struct_indirect_1) // Should not be byval. // CHECK-LABEL: define {{.*}} void @take_struct_indirect_1({{.*}}*{{( %.*)?}}) + +// Do a simple standalone test here of a function definition to ensure that +// we don't have problems due to failure to eagerly synthesize a copy +// constructor declaration. +class struct_trivial { + int x; +}; +// CHECK-LABEL define void @test_struct_trivial(i32{{( %.*)?}}) +extern "C" SWIFTCALL +void test_struct_trivial(struct_trivial triv) {}