maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[RISCV] Fix use of side-effects in asserts in decoder functions 

llvm-svn: 369580
This commit is contained in:
Luis Marques 2019-08-21 21:11:37 +00:00
parent 359840a6e4
commit 4f488b594a
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
llvm/lib/Target/RISCV/Disassembler/RISCVDisassembler.cpp
View File

@ -303,8 +303,9 @@ static DecodeStatus decodeRVCInstrSImm(MCInst &Inst, unsigned Insn,
uint64_t Address, const void *Decoder) {
uint64_t SImm6 =
fieldFromInstruction(Insn, 12, 1) << 5 | fieldFromInstruction(Insn, 2, 5);
assert(decodeSImmOperand<6>(Inst, SImm6, Address, Decoder) ==
MCDisassembler::Success && "Invalid immediate");
DecodeStatus Result = decodeSImmOperand<6>(Inst, SImm6, Address, Decoder);
(void)Result;
assert(Result == MCDisassembler::Success && "Invalid immediate");
(void)SImm6;
return MCDisassembler::Success;
}
@ -315,8 +316,9 @@ static DecodeStatus decodeRVCInstrRdSImm(MCInst &Inst, unsigned Insn,
DecodeGPRRegisterClass(Inst, 0, Address, Decoder);
uint64_t SImm6 =
fieldFromInstruction(Insn, 12, 1) << 5 | fieldFromInstruction(Insn, 2, 5);
assert(decodeSImmOperand<6>(Inst, SImm6, Address, Decoder) ==
MCDisassembler::Success && "Invalid immediate");
DecodeStatus Result = decodeSImmOperand<6>(Inst, SImm6, Address, Decoder);
(void)Result;
assert(Result == MCDisassembler::Success && "Invalid immediate");
(void)SImm6;
return MCDisassembler::Success;
}
@ -328,8 +330,9 @@ static DecodeStatus decodeRVCInstrRdRs1UImm(MCInst &Inst, unsigned Insn,
Inst.addOperand(Inst.getOperand(0));
uint64_t UImm6 =
fieldFromInstruction(Insn, 12, 1) << 5 | fieldFromInstruction(Insn, 2, 5);
assert(decodeUImmOperand<6>(Inst, UImm6, Address, Decoder) ==
MCDisassembler::Success && "Invalid immediate");
DecodeStatus Result = decodeUImmOperand<6>(Inst, UImm6, Address, Decoder);
(void)Result;
assert(Result == MCDisassembler::Success && "Invalid immediate");
(void)UImm6;
return MCDisassembler::Success;
}