maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

reenable factoring of GEP expressions, being more precise about the 

case that it bad to do.

llvm-svn: 31563
This commit is contained in:
Chris Lattner 2006-11-08 19:42:28 +00:00
parent cd62f11227
commit 4f218d56f5
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
llvm/lib/Transforms/Scalar/InstructionCombining.cpp
View File

@ -6788,12 +6788,17 @@ Instruction *InstCombiner::FoldPHIArgBinOpIntoPHI(PHINode &PN) {
if (I->getOperand(1) != RHSVal) RHSVal = 0; if (I->getOperand(1) != RHSVal) RHSVal = 0;
} }
// Otherwise, this is safe and profitable to transform. Create up to two phi // Otherwise, this is safe to transform, determine if it is profitable.
// nodes.
PHINode *NewLHS = 0, *NewRHS = 0; // If this is a GEP, and if the index (not the pointer) needs a PHI, bail out.
// Indexes are often folded into load/store instructions, so we don't want to
// hide them behind a phi.
if (isa<GetElementPtrInst>(FirstInst) && RHSVal == 0)
return 0;
Value *InLHS = FirstInst->getOperand(0); Value *InLHS = FirstInst->getOperand(0);
Value *InRHS = FirstInst->getOperand(1); Value *InRHS = FirstInst->getOperand(1);
PHINode *NewLHS = 0, *NewRHS = 0;
if (LHSVal == 0) { if (LHSVal == 0) {
NewLHS = new PHINode(LHSType, FirstInst->getOperand(0)->getName()+".pn"); NewLHS = new PHINode(LHSType, FirstInst->getOperand(0)->getName()+".pn");
NewLHS->reserveOperandSpace(PN.getNumOperands()/2); NewLHS->reserveOperandSpace(PN.getNumOperands()/2);
@ -6875,7 +6880,7 @@ Instruction *InstCombiner::FoldPHIArgOpIntoPHI(PHINode &PN) {
!isSafeToSinkLoad(LI)) !isSafeToSinkLoad(LI))
return 0; return 0;
} else if (isa<GetElementPtrInst>(FirstInst)) { } else if (isa<GetElementPtrInst>(FirstInst)) {
if (0 && FirstInst->getNumOperands() == 2) if (FirstInst->getNumOperands() == 2)
return FoldPHIArgBinOpIntoPHI(PN); return FoldPHIArgBinOpIntoPHI(PN);
// Can't handle general GEPs yet. // Can't handle general GEPs yet.
return 0; return 0;