maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[AArch64] Fix scalar vuqadd intrinsics operands 

Summary:
Change the vuqadd scalar instrinsics to have the second argument as unsigned values, not signed,
accordingly to https://developer.arm.com/architectures/instruction-sets/simd-isas/neon/intrinsics

So now the compiler correctly warns that a undefined negative float conversion is being done.

Reviewers: LukeCheeseman, john.brawn

Reviewed By: john.brawn

Subscribers: john.brawn, javed.absar, kristof.beyls, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D64242

llvm-svn: 365300
This commit is contained in:
Diogo N. Sampaio 2019-07-08 08:47:47 +00:00
parent 7d63be09b6
commit 4ec445b813
3 changed files with 31 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clang/include/clang/Basic/arm_neon.td
View File

@ -1333,7 +1333,7 @@ def SCALAR_SQNEG : SInst<"vqneg", "ss", "ScSsSiSl">;
////////////////////////////////////////////////////////////////////////////////
// Scalar Signed Saturating Accumulated of Unsigned Value
def SCALAR_SUQADD : SInst<"vuqadd", "sss", "ScSsSiSl">;
def SCALAR_SUQADD : SInst<"vuqadd", "ssb", "ScSsSiSl">;
////////////////////////////////////////////////////////////////////////////////
// Scalar Unsigned Saturating Accumulated of Signed Value

8
clang/test/CodeGen/aarch64-neon-intrinsics.c
View File

@ -13879,7 +13879,7 @@ int64_t test_vqnegd_s64(int64_t a) {
// CHECK: [[VUQADDB_S8_I:%.*]] = call <8 x i8> @llvm.aarch64.neon.suqadd.v8i8(<8 x i8> [[TMP0]], <8 x i8> [[TMP1]])
// CHECK: [[TMP2:%.*]] = extractelement <8 x i8> [[VUQADDB_S8_I]], i64 0
// CHECK: ret i8 [[TMP2]]
int8_t test_vuqaddb_s8(int8_t a, int8_t b) {
int8_t test_vuqaddb_s8(int8_t a, uint8_t b) {
return (int8_t)vuqaddb_s8(a, b);
}
@ -13889,21 +13889,21 @@ int8_t test_vuqaddb_s8(int8_t a, int8_t b) {
// CHECK: [[VUQADDH_S16_I:%.*]] = call <4 x i16> @llvm.aarch64.neon.suqadd.v4i16(<4 x i16> [[TMP0]], <4 x i16> [[TMP1]])
// CHECK: [[TMP2:%.*]] = extractelement <4 x i16> [[VUQADDH_S16_I]], i64 0
// CHECK: ret i16 [[TMP2]]
int16_t test_vuqaddh_s16(int16_t a, int16_t b) {
int16_t test_vuqaddh_s16(int16_t a, uint16_t b) {
return (int16_t)vuqaddh_s16(a, b);
}
// CHECK-LABEL: @test_vuqadds_s32(
// CHECK: [[VUQADDS_S32_I:%.*]] = call i32 @llvm.aarch64.neon.suqadd.i32(i32 %a, i32 %b)
// CHECK: ret i32 [[VUQADDS_S32_I]]
int32_t test_vuqadds_s32(int32_t a, int32_t b) {
int32_t test_vuqadds_s32(int32_t a, uint32_t b) {
return (int32_t)vuqadds_s32(a, b);
}
// CHECK-LABEL: @test_vuqaddd_s64(
// CHECK: [[VUQADDD_S64_I:%.*]] = call i64 @llvm.aarch64.neon.suqadd.i64(i64 %a, i64 %b)
// CHECK: ret i64 [[VUQADDD_S64_I]]
int64_t test_vuqaddd_s64(int64_t a, int64_t b) {
int64_t test_vuqaddd_s64(int64_t a, uint64_t b) {
return (int64_t)vuqaddd_s64(a, b);
}

26
clang/test/CodeGen/aarch64-neon-vuqadd-float-conversion-warning.c Normal file
View File

@ -0,0 +1,26 @@
// RUN: %clang_cc1 -triple arm64-none-linux-gnu -target-feature +neon \
// RUN: -S -disable-O0-optnone -emit-llvm -o - %s 2>&1 | FileCheck %s
#include <arm_neon.h>
// Check float conversion is not accepted for unsigned int argument
int8_t test_vuqaddb_s8(){
return vuqaddb_s8(1, -1.0f);
}
int16_t test_vuqaddh_s16() {
return vuqaddh_s16(1, -1.0f);
}
int32_t test_vuqadds_s32() {
return vuqadds_s32(1, -1.0f);
}
int64_t test_vuqaddd_s64() {
return vuqaddd_s64(1, -1.0f);
}
// CHECK: warning: implicit conversion of out of range value from 'float' to 'uint8_t' (aka 'unsigned char') is undefined
// CHECK: warning: implicit conversion of out of range value from 'float' to 'uint16_t' (aka 'unsigned short') is undefined
// CHECK: warning: implicit conversion of out of range value from 'float' to 'uint32_t' (aka 'unsigned int') is undefined
// CHECK: warning: implicit conversion of out of range value from 'float' to 'uint64_t' (aka 'unsigned long') is undefined