maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Fix rdar://5905347 a crash on invalid builtin, due to the 

params not getting installed for builtins when synthesized.

llvm-svn: 50676
This commit is contained in:
Chris Lattner 2008-05-05 22:18:14 +00:00
parent dbfcce37fe
commit 4dd2710222
2 changed files with 25 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
clang/lib/Sema/SemaDecl.cpp
View File

@ -143,8 +143,7 @@ Decl *Sema::LookupDecl(const IdentifierInfo *II, unsigned NSI,
return 0;
}
void Sema::InitBuiltinVaListType()
{
void Sema::InitBuiltinVaListType() {
if (!Context.getBuiltinVaListType().isNull())
return;
@ -161,8 +160,8 @@ ScopedDecl *Sema::LazilyCreateBuiltin(IdentifierInfo *II, unsigned bid,
Builtin::ID BID = (Builtin::ID)bid;
if (BID == Builtin::BI__builtin_va_start ||
BID == Builtin::BI__builtin_va_copy ||
BID == Builtin::BI__builtin_va_end)
BID == Builtin::BI__builtin_va_copy ||
BID == Builtin::BI__builtin_va_end)
InitBuiltinVaListType();
QualType R = Context.BuiltinInfo.GetBuiltinType(BID, Context);
@ -171,6 +170,19 @@ ScopedDecl *Sema::LazilyCreateBuiltin(IdentifierInfo *II, unsigned bid,
SourceLocation(), II, R,
FunctionDecl::Extern, false, 0);
// Create Decl objects for each parameter, adding them to the
// FunctionDecl.
if (FunctionTypeProto *FT = dyn_cast<FunctionTypeProto>(R)) {
llvm::SmallVector<ParmVarDecl*, 16> Params;
for (unsigned i = 0, e = FT->getNumArgs(); i != e; ++i)
Params.push_back(ParmVarDecl::Create(Context, New, SourceLocation(), 0,
FT->getArgType(i), VarDecl::None, 0,
0));
New->setParams(&Params[0], Params.size());
}
// TUScope is the translation-unit scope to insert this function into.
TUScope->AddDecl(New);

9
clang/test/Sema/builtins.c
View File

@ -30,3 +30,12 @@ void cfstring() {
CFSTR("foo", "bar"); // expected-error {{ error: too many arguments to function }}
}
typedef __attribute__(( ext_vector_type(16) )) unsigned char uchar16; // expected-warning {{extension}}
// rdar://5905347
unsigned char foo( short v ) {
uchar16 c;
return __builtin_ia32_vec_ext_v4si( c ); // expected-error {{too few arguments to function}}
}