maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Delete the buffer in createObjectFile if it fails. 

The Binary constructor takes ownership of the memory buffer. This is a fairly
unfortunate interface, but for now make createObjectFile consistent with it
by also deleting the buffer if it fails.

Fixes a leak in llvm-ar found by the valgrind bots.

llvm-svn: 187039
This commit is contained in:
Rafael Espindola 2013-07-24 14:00:26 +00:00
parent 78bfe2b12e
commit 4d76a21bc7
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
llvm/lib/Object/ObjectFile.cpp
View File

@ -38,8 +38,10 @@ section_iterator ObjectFile::getRelocatedSection(DataRefImpl Sec) const {
}
ObjectFile *ObjectFile::createObjectFile(MemoryBuffer *Object) {
if (!Object || Object->getBufferSize() < 64)
if (Object->getBufferSize() < 64) {
delete Object;
return 0;
}
sys::fs::file_magic Type = sys::fs::identify_magic(Object->getBuffer());
switch (Type) {
@ -47,6 +49,7 @@ ObjectFile *ObjectFile::createObjectFile(MemoryBuffer *Object) {
case sys::fs::file_magic::bitcode:
case sys::fs::file_magic::archive:
case sys::fs::file_magic::macho_universal_binary:
delete Object;
return 0;
case sys::fs::file_magic::elf_relocatable:
case sys::fs::file_magic::elf_executable: