maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Fix broken asserts that never fire. 

Change assert("text") to assert(0 && "text").  The first case is a const char *
to bool conversion, which always evaluates to true, never triggering the
assert.  The second case will always trigger the assert.

llvm-svn: 185227
This commit is contained in:
Richard Trieu 2013-06-28 21:54:25 +00:00
parent 3192b2fcea
commit 4d18c9cc4e
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
llvm/include/llvm/TableGen/Record.h
View File

@ -1799,9 +1799,9 @@ struct LessRecordRegister {
unsigned LHSVal, RHSVal;
if (LHSPart.second.getAsInteger(10, LHSVal))
assert("Unable to convert LHS to integer.");
assert(0 && "Unable to convert LHS to integer.");
if (RHSPart.second.getAsInteger(10, RHSVal))
assert("Unable to convert RHS to integer.");
assert(0 && "Unable to convert RHS to integer.");
if (LHSVal != RHSVal)
return LHSVal < RHSVal;
}

4
llvm/lib/Target/Hexagon/InstPrinter/HexagonInstPrinter.cpp
View File

@ -179,7 +179,7 @@ void HexagonInstPrinter::printBranchOperand(const MCInst *MI, unsigned OpNo,
raw_ostream &O) const {
// Branches can take an immediate operand. This is used by the branch
// selection pass to print $+8, an eight byte displacement from the PC.
assert("Unknown branch operand.");
assert(0 && "Unknown branch operand.");
}
void HexagonInstPrinter::printCallOperand(const MCInst *MI, unsigned OpNo,
@ -203,7 +203,7 @@ void HexagonInstPrinter::printSymbol(const MCInst *MI, unsigned OpNo,
O << '#';
printOperand(MI, OpNo, O);
} else {
assert("Unknown symbol operand");
assert(0 && "Unknown symbol operand");
printOperand(MI, OpNo, O);
}
O << ')';