maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Add override specifiers to Symbolizer methods. NFC. 

llvm-svn: 223094
This commit is contained in:
Alexey Samsonov 2014-12-01 23:47:51 +00:00
parent afcd8dbbcf
commit 4cdf4eba74
2 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc
View File

@ -514,7 +514,7 @@ class POSIXSymbolizer : public Symbolizer {
internal_symbolizer_(internal_symbolizer),
libbacktrace_symbolizer_(libbacktrace_symbolizer) {}
uptr SymbolizePC(uptr addr, AddressInfo *frames, uptr max_frames) {
uptr SymbolizePC(uptr addr, AddressInfo *frames, uptr max_frames) override {
BlockingMutexLock l(&mu_);
if (max_frames == 0)
return 0;
@ -582,7 +582,7 @@ class POSIXSymbolizer : public Symbolizer {
return frame_id;
}
bool SymbolizeData(uptr addr, DataInfo *info) {
bool SymbolizeData(uptr addr, DataInfo *info) override {
BlockingMutexLock l(&mu_);
LoadedModule *module = FindModuleForAddress(addr);
if (module == 0)
@ -609,17 +609,17 @@ class POSIXSymbolizer : public Symbolizer {
}
bool GetModuleNameAndOffsetForPC(uptr pc, const char **module_name,
uptr *module_address) {
uptr *module_address) override {
BlockingMutexLock l(&mu_);
return FindModuleNameAndOffsetForAddress(pc, module_name, module_address);
}
bool CanReturnFileLineInfo() {
bool CanReturnFileLineInfo() override {
return internal_symbolizer_ != 0 || external_symbolizer_ != 0 ||
libbacktrace_symbolizer_ != 0;
}
void Flush() {
void Flush() override {
BlockingMutexLock l(&mu_);
if (internal_symbolizer_ != 0) {
SymbolizerScope sym_scope(this);
@ -627,7 +627,7 @@ class POSIXSymbolizer : public Symbolizer {
}
}
const char *Demangle(const char *name) {
const char *Demangle(const char *name) override {
BlockingMutexLock l(&mu_);
// Run hooks even if we don't use internal symbolizer, as cxxabi
// demangle may call system functions.
@ -642,7 +642,7 @@ class POSIXSymbolizer : public Symbolizer {
return DemangleCXXABI(name);
}
void PrepareForSandboxing() {
void PrepareForSandboxing() override {
#if SANITIZER_LINUX && !SANITIZER_ANDROID
BlockingMutexLock l(&mu_);
// Cache /proc/self/exe on Linux.

6
compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_win.cc
View File

@ -26,7 +26,7 @@ class WinSymbolizer : public Symbolizer {
public:
WinSymbolizer() : initialized_(false) {}
uptr SymbolizePC(uptr addr, AddressInfo *frames, uptr max_frames) {
uptr SymbolizePC(uptr addr, AddressInfo *frames, uptr max_frames) override {
if (max_frames == 0)
return 0;
@ -85,11 +85,11 @@ class WinSymbolizer : public Symbolizer {
return 1;
}
bool CanReturnFileLineInfo() {
bool CanReturnFileLineInfo() override {
return true;
}
const char *Demangle(const char *name) {
const char *Demangle(const char *name) override {
CHECK(initialized_);
static char demangle_buffer[1000];
if (name[0] == '\01' &&