maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[BOLT] Fix function order output option 

Summary:
Add support to output both function order and section order files
as the former is useful for offloading functions sorting and
the latter is useful for linker script generation:

  -generate-function-order=<file>
  -generate-link-sections=<file>

(cherry picked from FBD6078446)
This commit is contained in:
Maksim Panchenko 2017-10-17 10:05:16 -07:00
parent bee9132a54
commit 4c8f48be3d
1 changed files with 52 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

70
bolt/Passes/ReorderFunctions.cpp
View File

@ -75,6 +75,12 @@ GenerateFunctionOrderFile("generate-function-order",
"reordering"),
cl::cat(BoltOptCategory));
static cl::opt<std::string>
LinkSectionsFile("generate-link-sections",
cl::desc("generate a list of function sections in a format suitable for "
"inclusion in a linker script"),
cl::cat(BoltOptCategory));
static cl::opt<bool>
UseEdgeCounts("use-edge-counts",
cl::desc("use edge count data when doing clustering"),
@ -408,16 +414,32 @@ void ReorderFunctions::runOnFunctions(BinaryContext &BC,
reorder(std::move(Clusters), BFs);
std::unique_ptr<std::ofstream> FuncsFile;
if (!opts::GenerateFunctionOrderFile.empty()) {
std::ofstream FuncsFile(opts::GenerateFunctionOrderFile, std::ios::out);
FuncsFile =
llvm::make_unique<std::ofstream>(opts::GenerateFunctionOrderFile,
std::ios::out);
if (!FuncsFile) {
errs() << "Ordered functions file \"" << opts::GenerateFunctionOrderFile
<< "\" can't be opened.\n";
errs() << "BOLT-ERROR: ordered functions file "
<< opts::GenerateFunctionOrderFile << " cannot be opened\n";
exit(1);
}
}
std::unique_ptr<std::ofstream> LinkSectionsFile;
if (!opts::LinkSectionsFile.empty()) {
LinkSectionsFile =
llvm::make_unique<std::ofstream>(opts::LinkSectionsFile,
std::ios::out);
if (!LinkSectionsFile) {
errs() << "BOLT-ERROR: link sections file "
<< opts::LinkSectionsFile << " cannot be opened\n";
exit(1);
}
}
if (FuncsFile || LinkSectionsFile) {
std::vector<BinaryFunction *> SortedFunctions(BFs.size());
std::transform(BFs.begin(),
BFs.end(),
SortedFunctions.begin(),
@ -446,25 +468,37 @@ void ReorderFunctions::runOnFunctions(BinaryContext &BC,
break;
if (Func->isPLTFunction())
continue;
const char *Indent = "";
for (auto Name : Func->getNames()) {
const auto SlashPos = Name.find('/');
if (SlashPos != std::string::npos) {
// Avoid duplicates for local functions.
if (Name.find('/', SlashPos + 1) != std::string::npos)
continue;
Name = Name.substr(0, SlashPos);
if (FuncsFile)
*FuncsFile << Func->getSymbol()->getName().data() << "\n";
if (LinkSectionsFile) {
const char *Indent = "";
for (auto Name : Func->getNames()) {
const auto SlashPos = Name.find('/');
if (SlashPos != std::string::npos) {
// Avoid duplicates for local functions.
if (Name.find('/', SlashPos + 1) != std::string::npos)
continue;
Name = Name.substr(0, SlashPos);
}
*LinkSectionsFile << Indent << ".text." << Name << "\n";
Indent = " ";
}
FuncsFile << Indent << ".text." << Name << "\n";
Indent = " ";
}
}
FuncsFile.close();
outs() << "BOLT-INFO: dumped function order to \""
<< opts::GenerateFunctionOrderFile << "\"\n";
if (FuncsFile) {
FuncsFile->close();
outs() << "BOLT-INFO: dumped function order to "
<< opts::GenerateFunctionOrderFile << '\n';
}
exit(0);
if (LinkSectionsFile) {
LinkSectionsFile->close();
outs() << "BOLT-INFO: dumped linker section order to "
<< opts::LinkSectionsFile << '\n';
}
}
}