maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[clang-tidy] Do not show incorrect fix in modernize-make-unique 

Summary:
The case when initialize_list hides behind an implicit case was not
handled before.

Reviewers: aaron.ballman

Reviewed By: aaron.ballman

Subscribers: xazax.hun, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D61642

llvm-svn: 360231
This commit is contained in:
Ilya Biryukov 2019-05-08 08:52:18 +00:00
parent e96c98f37d
commit 4c32d4fd9f
2 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp
View File

@ -292,12 +292,13 @@ bool MakeSmartPtrCheck::replaceNew(DiagnosticBuilder &Diag,
// Foo{1} => false
auto HasListIntializedArgument = [](const CXXConstructExpr *CE) {
for (const auto *Arg : CE->arguments()) {
Arg = Arg->IgnoreImplicit();
if (isa<CXXStdInitializerListExpr>(Arg) || isa<InitListExpr>(Arg))
return true;
// Check whether we implicitly construct a class from a
// std::initializer_list.
if (const auto *ImplicitCE =
dyn_cast<CXXConstructExpr>(Arg->IgnoreImplicit())) {
if (const auto *ImplicitCE = dyn_cast<CXXConstructExpr>(Arg)) {
if (ImplicitCE->isStdInitListInitialization())
return true;
}

8
clang-tools-extra/test/clang-tidy/modernize-make-unique.cpp
View File

@ -273,6 +273,14 @@ void initialization(int T, Base b) {
// CHECK-MESSAGES: :[[@LINE-1]]:9: warning: use std::make_unique instead
// CHECK-FIXES: std::make_unique<APair>(APair{T, 1});
// Check aggregate init with intermediate temporaries.
std::unique_ptr<APair> PAggrTemp = std::unique_ptr<APair>(new APair({T, 1}));
// CHECK-MESSAGES: :[[@LINE-1]]:38: warning: use std::make_unique instead
// CHECK-FIXES: std::unique_ptr<APair> PAggrTemp = std::unique_ptr<APair>(new APair({T, 1}));
PAggrTemp.reset(new APair({T, 1}));
// CHECK-MESSAGES: :[[@LINE-1]]:13: warning: use std::make_unique instead
// CHECK-FIXES: PAggrTemp.reset(new APair({T, 1}));
// Test different kinds of initialization of the pointee, when the unique_ptr
// is initialized with braces.