maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

C++/ABI/i386: Member function pointers should be passed by value. 

llvm-svn: 103842
This commit is contained in:
Daniel Dunbar 2010-05-15 00:00:30 +00:00
parent be4556f550
commit 4bd95c65e7
2 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
clang/lib/CodeGen/TargetInfo.cpp
View File

@ -387,10 +387,11 @@ bool X86_32ABIInfo::shouldReturnTypeInRegister(QualType Ty,
return true;
}
// If this is a builtin, pointer, enum, or complex type, it is ok.
// If this is a builtin, pointer, enum, complex type, member pointer, or
// member function pointer it is ok.
if (Ty->getAs<BuiltinType>() || Ty->hasPointerRepresentation() ||
Ty->isAnyComplexType() || Ty->isEnumeralType() ||
Ty->isBlockPointerType())
Ty->isBlockPointerType() || Ty->isMemberPointerType())
return true;
// Arrays are treated like records.

9
clang/test/CodeGenCXX/x86_32-arguments.cpp
View File

@ -87,3 +87,12 @@ s4_2 f4() { return s4_2(); }
// CHECK: define i32 @_Z2f5v()
struct s5 { s5(); int &x; };
s5 f5() { return s5(); }
// CHECK: define i32 @_Z4f6_0M2s6i(i32 %a)
// CHECK: define i64 @_Z4f6_1M2s6FivE(%{{.*}} byval %a)
// FIXME: It would be nice to avoid byval on the previous case.
struct s6 {};
typedef int s6::* s6_mdp;
typedef int (s6::*s6_mfp)();
s6_mdp f6_0(s6_mdp a) { return a; }
s6_mfp f6_1(s6_mfp a) { return a; }