Walk back commits for unused function parameters - they're still being

used via dragonegg for now.

llvm-svn: 208016
This commit is contained in:
Eric Christopher 2014-05-05 23:26:59 +00:00
parent ef8a951882
commit 4b33ec96d3
2 changed files with 20 additions and 6 deletions

View File

@ -78,7 +78,7 @@ public:
std::string getString() const; std::string getString() const;
/// Adding Features. /// Adding Features.
void AddFeature(const StringRef String); void AddFeature(const StringRef String, bool IsEnabled = true);
/// ToggleFeature - Toggle a feature and returns the newly updated feature /// ToggleFeature - Toggle a feature and returns the newly updated feature
/// bits. /// bits.

View File

@ -51,6 +51,18 @@ static inline bool isEnabled(const StringRef Feature) {
return Ch == '+'; return Ch == '+';
} }
/// PrependFlag - Return a string with a prepended flag; '+' or '-'.
///
static inline std::string PrependFlag(const StringRef Feature,
bool IsEnabled) {
assert(!Feature.empty() && "Empty string");
if (hasFlag(Feature))
return Feature;
std::string Prefix = IsEnabled ? "+" : "-";
Prefix += Feature;
return Prefix;
}
/// Split - Splits a string of comma separated items in to a vector of strings. /// Split - Splits a string of comma separated items in to a vector of strings.
/// ///
static void Split(std::vector<std::string> &V, const StringRef S) { static void Split(std::vector<std::string> &V, const StringRef S) {
@ -97,11 +109,13 @@ static std::string Join(const std::vector<std::string> &V) {
} }
/// Adding features. /// Adding features.
void SubtargetFeatures::AddFeature(const StringRef String) { void SubtargetFeatures::AddFeature(const StringRef String,
// Don't add empty features or features we already have. bool IsEnabled) {
if (!String.empty()) // Don't add empty features
// Convert to lowercase, prepend flag if we don't already have a flag. if (!String.empty()) {
Features.push_back(hasFlag(String) ? String.str() : "+" + String.lower()); // Convert to lowercase, prepend flag and add to vector
Features.push_back(PrependFlag(String.lower(), IsEnabled));
}
} }
/// Find KV in array using binary search. /// Find KV in array using binary search.