maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Don't setCalleeSavedInfoValid() until spills are interted. 

In a naked function, the flag is never set and getPristineRegs() returns an
empty list. That means naked functions are able to clobber callee saved
registers, but that is the whole point of naked functions.

This fixes PR4716.

llvm-svn: 79096
This commit is contained in:
Jakob Stoklund Olesen 2009-08-15 13:10:46 +00:00
parent 766352fbd2
commit 4af3c864bc
2 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
llvm/lib/CodeGen/PrologEpilogInserter.cpp
View File

@ -214,8 +214,6 @@ void PEI::calculateCalleeSavedRegisters(MachineFunction &Fn) {
}
}
FFI->setCalleeSavedInfoValid(true);
if (CSI.empty())
return; // Early exit if no callee saved registers are modified!
@ -274,6 +272,8 @@ void PEI::insertCSRSpillsAndRestores(MachineFunction &Fn) {
MachineFrameInfo *FFI = Fn.getFrameInfo();
const std::vector<CalleeSavedInfo> &CSI = FFI->getCalleeSavedInfo();
FFI->setCalleeSavedInfoValid(true);
// Early exit if no callee saved registers are modified!
if (CSI.empty())
return;

10
llvm/test/CodeGen/ARM/2009-08-15-RegScavengerAssert.ll Normal file
View File

@ -0,0 +1,10 @@
; RUN: llvm-as < %s | llc -march=arm
; PR4716
define arm_aapcscc void @_start() nounwind naked {
entry:
tail call arm_aapcscc void @exit(i32 undef) noreturn nounwind
unreachable
}
declare arm_aapcscc void @exit(i32) noreturn nounwind