From 4aad12ce0bf77b0802e0745adde61265e0ab3aed Mon Sep 17 00:00:00 2001 From: Sam Clegg Date: Thu, 27 Sep 2018 00:46:54 +0000 Subject: [PATCH] [WebAssembly] Update Config member to match command line option Subscribers: dschuff, jgravelle-google, aheejin, sunfish, llvm-commits Differential Revision: https://reviews.llvm.org/D50976 llvm-svn: 343157 --- lld/wasm/Config.h | 2 +- lld/wasm/Driver.cpp | 6 +++--- lld/wasm/InputChunks.cpp | 4 ++-- lld/wasm/InputChunks.h | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/lld/wasm/Config.h b/lld/wasm/Config.h index ae8989f15d74..e100ab82a590 100644 --- a/lld/wasm/Config.h +++ b/lld/wasm/Config.h @@ -20,7 +20,7 @@ namespace wasm { struct Configuration { bool AllowUndefined; - bool CompressRelocTargets; + bool CompressRelocations; bool Demangle; bool DisableVerify; bool ExportAll; diff --git a/lld/wasm/Driver.cpp b/lld/wasm/Driver.cpp index 789bda90b1a8..897855873046 100644 --- a/lld/wasm/Driver.cpp +++ b/lld/wasm/Driver.cpp @@ -396,7 +396,7 @@ void LinkerDriver::link(ArrayRef ArgsArr) { Config->SearchPaths = args::getStrings(Args, OPT_L); Config->StripAll = Args.hasArg(OPT_strip_all); Config->StripDebug = Args.hasArg(OPT_strip_debug); - Config->CompressRelocTargets = Args.hasArg(OPT_compress_relocations); + Config->CompressRelocations = Args.hasArg(OPT_compress_relocations); Config->StackFirst = Args.hasArg(OPT_stack_first); Config->ThinLTOCacheDir = Args.getLastArgValue(OPT_thinlto_cache_dir); Config->ThinLTOCachePolicy = CHECK( @@ -412,7 +412,7 @@ void LinkerDriver::link(ArrayRef ArgsArr) { Config->ZStackSize = args::getZOptionValue(Args, OPT_z, "stack-size", WasmPageSize); - if (!Config->StripDebug && !Config->StripAll && Config->CompressRelocTargets) + if (!Config->StripDebug && !Config->StripAll && Config->CompressRelocations) error("--compress-relocations is incompatible with output debug" " information. Please pass --strip-debug or --strip-all"); @@ -442,7 +442,7 @@ void LinkerDriver::link(ArrayRef ArgsArr) { error("entry point specified for relocatable output file"); if (Config->GcSections) error("-r and --gc-sections may not be used together"); - if (Config->CompressRelocTargets) + if (Config->CompressRelocations) error("-r -and --compress-relocations may not be used together"); if (Args.hasArg(OPT_undefined)) error("-r -and --undefined may not be used together"); diff --git a/lld/wasm/InputChunks.cpp b/lld/wasm/InputChunks.cpp index ed658366b5dc..87aac5a4af52 100644 --- a/lld/wasm/InputChunks.cpp +++ b/lld/wasm/InputChunks.cpp @@ -220,7 +220,7 @@ static unsigned getRelocWidth(const WasmRelocation &Rel, uint32_t Value) { // This function only computes the final output size. It must be called // before getSize() is used to calculate of layout of the code section. void InputFunction::calculateSize() { - if (!File || !Config->CompressRelocTargets) + if (!File || !Config->CompressRelocations) return; LLVM_DEBUG(dbgs() << "calculateSize: " << getName() << "\n"); @@ -255,7 +255,7 @@ void InputFunction::calculateSize() { // Override the default writeTo method so that we can (optionally) write the // compressed version of the function. void InputFunction::writeTo(uint8_t *Buf) const { - if (!File || !Config->CompressRelocTargets) + if (!File || !Config->CompressRelocations) return InputChunk::writeTo(Buf); Buf += OutputOffset; diff --git a/lld/wasm/InputChunks.h b/lld/wasm/InputChunks.h index 2ab4ae8983ad..f899d697c6dc 100644 --- a/lld/wasm/InputChunks.h +++ b/lld/wasm/InputChunks.h @@ -138,7 +138,7 @@ public: uint32_t getFunctionInputOffset() const { return getInputSectionOffset(); } uint32_t getFunctionCodeOffset() const { return Function->CodeOffset; } uint32_t getSize() const override { - if (Config->CompressRelocTargets && File) { + if (Config->CompressRelocations && File) { assert(CompressedSize); return CompressedSize; } @@ -165,7 +165,7 @@ public: protected: ArrayRef data() const override { - assert(!Config->CompressRelocTargets); + assert(!Config->CompressRelocations); return File->CodeSection->Content.slice(getInputSectionOffset(), Function->Size); }