maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

When PromoteLocallyUsedAllocas promoted allocas, it didn't remember 

to increment NumLocalPromoted, and didn't actually delete the
dead alloca, leading to an extra iteration of mem2reg.

llvm-svn: 40817
This commit is contained in:
Chris Lattner 2007-08-04 20:01:43 +00:00
parent 63c039780c
commit 4a930f9444
1 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
llvm/lib/Transforms/Utils/PromoteMemoryToRegister.cpp
View File

@ -686,10 +686,10 @@ bool PromoteMem2Reg::PromoteLocallyUsedAlloca(BasicBlock *BB, AllocaInst *AI) {
}
// After traversing the basic block, there should be no more uses of the
// alloca, remove it now.
// alloca: remove it now.
assert(AI->use_empty() && "Uses of alloca from more than one BB??");
if (AST) AST->deleteValue(AI);
AI->getParent()->getInstList().erase(AI);
AI->eraseFromParent();
++NumLocalPromoted;
return false;
@ -739,6 +739,17 @@ PromoteLocallyUsedAllocas(BasicBlock *BB, const std::vector<AllocaInst*> &AIs) {
}
}
}
// At the end of the block scan, all allocas in CurValues are dead.
for (DenseMap<AllocaInst*, Value*>::iterator I = CurValues.begin(),
E = CurValues.end(); I != E; ++I) {
AllocaInst *AI = I->first;
assert(AI->use_empty() && "Uses of alloca from more than one BB??");
if (AST) AST->deleteValue(AI);
AI->eraseFromParent();
}
NumLocalPromoted += CurValues.size();
}