maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Fix missed case of switching getConstant to getTargetConstant. Try 2. 

Summary: This fixes a crasher introduced by r372338.

Reviewers: echristo, arsenm

Subscribers: wdng, hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D67850

llvm-svn: 372434
This commit is contained in:
Sterling Augustine 2019-09-20 22:26:55 +00:00
parent eacbe1cccc
commit 4a58936716
2 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
llvm/lib/Target/X86/X86ISelLowering.cpp
View File

@ -17608,7 +17608,7 @@ SDValue X86TargetLowering::LowerINSERT_VECTOR_ELT(SDValue Op,
// operand form. // operand form.
N1 = DAG.getNode(ISD::SCALAR_TO_VECTOR, dl, MVT::v4f32, N1); N1 = DAG.getNode(ISD::SCALAR_TO_VECTOR, dl, MVT::v4f32, N1);
return DAG.getNode(X86ISD::BLENDI, dl, VT, N0, N1, return DAG.getNode(X86ISD::BLENDI, dl, VT, N0, N1,
DAG.getConstant(1, dl, MVT::i8)); DAG.getTargetConstant(1, dl, MVT::i8));
} }
// Create this as a scalar to vector.. // Create this as a scalar to vector..
N1 = DAG.getNode(ISD::SCALAR_TO_VECTOR, dl, MVT::v4f32, N1); N1 = DAG.getNode(ISD::SCALAR_TO_VECTOR, dl, MVT::v4f32, N1);

19
llvm/test/CodeGen/X86/isel-blendi-gettargetconstant.ll Normal file
View File

@ -0,0 +1,19 @@
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
; RUN: llc < %s -mtriple=x86_64-linux-gnu -mattr=sse4.2 | FileCheck %s
define void @csrot_(float* %0) {
; CHECK-LABEL: csrot_:
; CHECK: # %bb.0:
; CHECK-NEXT: movss {{.*#+}} xmm0 = mem[0],zero,zero,zero
; CHECK-NEXT: movss {{.*#+}} xmm1 = mem[0],zero,zero,zero
; CHECK-NEXT: xorps %xmm0, %xmm1
; CHECK-NEXT: blendps {{.*#+}} xmm1 = xmm1[0],mem[1,2,3]
; CHECK-NEXT: movlps %xmm1, (%rax)
; CHECK-NEXT: retq
1:
%2 = load float, float* %0, align 4
%3 = fsub float -0.000000e+00, %2
%4 = insertelement <2 x float> <float undef, float -0.000000e+00>, float %3, i32 0
store <2 x float> %4, <2 x float>* undef, align 8
ret void
}