maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Specially handle casts to 'void' in AdjustedReturnValueChecker. 

llvm-svn: 95287
This commit is contained in:
Ted Kremenek 2010-02-04 04:18:55 +00:00
parent 33617e055a
commit 49f878524c
2 changed files with 17 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
clang/lib/Checker/AdjustedReturnValueChecker.cpp
View File

@ -43,6 +43,9 @@ void clang::RegisterAdjustedReturnValueChecker(GRExprEngine &Eng) {
void AdjustedReturnValueChecker::PostVisitCallExpr(CheckerContext &C, void AdjustedReturnValueChecker::PostVisitCallExpr(CheckerContext &C,
const CallExpr *CE) { const CallExpr *CE) {
// Get the result type of the call.
QualType expectedResultTy = CE->getType();
// Fetch the signature of the called function. // Fetch the signature of the called function.
const GRState *state = C.getState(); const GRState *state = C.getState();
@ -50,6 +53,12 @@ void AdjustedReturnValueChecker::PostVisitCallExpr(CheckerContext &C,
if (V.isUnknown()) if (V.isUnknown())
return; return;
// Casting to void? Discard the value.
if (expectedResultTy->isVoidType()) {
C.GenerateNode(state->BindExpr(CE, UnknownVal()));
return;
}
const MemRegion *callee = state->getSVal(CE->getCallee()).getAsRegion(); const MemRegion *callee = state->getSVal(CE->getCallee()).getAsRegion();
if (!callee) if (!callee)
return; return;
@ -76,8 +85,6 @@ void AdjustedReturnValueChecker::PostVisitCallExpr(CheckerContext &C,
if (actualResultTy->getAs<ReferenceType>()) if (actualResultTy->getAs<ReferenceType>())
return; return;
// Get the result type of the call.
QualType expectedResultTy = CE->getType();
// Are they the same? // Are they the same?
if (expectedResultTy != actualResultTy) { if (expectedResultTy != actualResultTy) {

8
clang/test/Analysis/misc-ps.m
View File

@ -893,3 +893,11 @@ int bar_rev95267() {
return 1; return 1;
return 0; return 0;
} }
// Same as previous case, but handle casts to 'void'.
int bar_rev95274() {
void (*Callback_rev95274)(void) = (void (*)(void)) foo_rev95267;
(*Callback_rev95274)();
return 0;
}