maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Don't resolve the path when we extract the path from the dyld info or we 

can end up with an invalid path if the path resolves to something different
on the local machine. It is very important not to since remote debugging will
mention paths that might exist on the current machine (like 
"/System/Library/Frameworks/CoreFoundation/CoreFoundation" which on the desktop
systems is a symlink to "/System/Library/Frameworks/CoreFoundation/Versions/A/CoreFoundation").

We will let the platform plug-ins resolve the paths in a later stage.

llvm-svn: 131934
This commit is contained in:
Greg Clayton 2011-05-23 23:14:34 +00:00
parent 61ae8d395e
commit 49c0fe24d6
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp
View File

@ -607,10 +607,9 @@ DynamicLoaderMacOSXDYLD::UpdateAllImageInfos()
char raw_path[PATH_MAX];
m_process->ReadCStringFromMemory (path_addr, raw_path, sizeof(raw_path));
char raw_path2[PATH_MAX];// TODO: remove after assertion doesn't assert
m_process->ReadMemory (path_addr, raw_path2, sizeof(raw_path2), error);// TODO: remove after assertion doesn't assert
assert (strcmp (raw_path, raw_path2) == 0);// TODO: remove after assertion doesn't assert
m_dyld_image_infos[i].file_spec.SetFile(raw_path, true);
// don't resolve the path
const bool resolve_path = false;
m_dyld_image_infos[i].file_spec.SetFile(raw_path, resolve_path);
}
assert(i == m_dyld_all_image_infos.dylib_info_count);