maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[Clang-Tidy] Quick fix for bug in bugprone-macro-parentheses 43804 

Applying parentheses for statement leads to compilation error. Bug
[[ 43804 | https://bugs.llvm.org/show_bug.cgi?id=43804 ]] is a
compilation error suggested by a wrong fix of this checker. This
patch is a quick fix for this issue.

Differential Revision: https://reviews.llvm.org/D70850
This commit is contained in:
Adam Balogh 2019-11-29 13:30:26 +01:00
parent 269c1c703d
commit 497a754ade
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clang-tools-extra/clang-tidy/bugprone/MacroParenthesesCheck.cpp
View File

@ -54,7 +54,7 @@ static bool isSurroundedRight(const Token &T) {
/// Is given TokenKind a keyword? /// Is given TokenKind a keyword?
static bool isKeyword(const Token &T) { static bool isKeyword(const Token &T) {
// FIXME: better matching of keywords to avoid false positives. // FIXME: better matching of keywords to avoid false positives.
return T.isOneOf(tok::kw_case, tok::kw_const, tok::kw_struct); return T.isOneOf(tok::kw_if, tok::kw_case, tok::kw_const, tok::kw_struct);
} }
/// Warning is written when one of these operators are not within parentheses. /// Warning is written when one of these operators are not within parentheses.

1
clang-tools-extra/test/clang-tidy/checkers/bugprone-macro-parentheses.cpp
View File

@ -43,6 +43,7 @@
#define GOOD30(args...) std::cout << args; #define GOOD30(args...) std::cout << args;
#define GOOD31(X) A*X=2 #define GOOD31(X) A*X=2
#define GOOD32(X) std::vector<X> #define GOOD32(X) std::vector<X>
#define GOOD33(x) if (!a__##x) a_##x = &f(#x)
// These are allowed for now.. // These are allowed for now..
#define MAYBE1 *12.34 #define MAYBE1 *12.34