maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[Axccel] Remove -Wno-missing-braces in build 

Summary:
I originally added the -Wno-missing-braces flag because I thought it was
erroneously flagging std::array initializations. Now I realize the extra
braces really are desired for these initializations, so I'm turning the
warning flag back on.

Reviewers: jlebar

Subscribers: mgorny, parallel_libs-commits

Differential Revision: https://reviews.llvm.org/D27941

llvm-svn: 290137
This commit is contained in:
Jason Henline 2016-12-19 21:34:07 +00:00
parent 5967c97323
commit 492c5a1674
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
parallel-libs/acxxel/CMakeLists.txt
View File

@ -35,7 +35,7 @@ set(CMAKE_CXX_STANDARD 11)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
# Add warning flags.
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -Wno-missing-braces")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra")
add_library(
acxxel

6
parallel-libs/acxxel/examples/opencl_example.cpp
View File

@ -57,9 +57,9 @@ void saxpy(float A, std::array<float, N> &X, const std::array<float, N> &Y) {
int main() {
float A = 2.f;
std::array<float, 3> X = {0.f, 1.f, 2.f};
std::array<float, 3> Y = {3.f, 4.f, 5.f};
std::array<float, 3> Expected = {3.f, 6.f, 9.f};
std::array<float, 3> X{{0.f, 1.f, 2.f}};
std::array<float, 3> Y{{3.f, 4.f, 5.f}};
std::array<float, 3> Expected{{3.f, 6.f, 9.f}};
saxpy(A, X, Y);
for (int I = 0; I < 3; ++I)
if (X[I] != Expected[I]) {

4
parallel-libs/acxxel/tests/span_test.cpp
View File

@ -79,12 +79,12 @@ TEST(Span, ArrayConstruction) {
}
TEST(Span, StdArrayConstruction) {
std::array<int, 3> Array{0, 1, 2};
std::array<int, 3> Array{{0, 1, 2}};
acxxel::Span<int> Span(Array);
EXPECT_EQ(Span.data(), Array.data());
EXPECT_EQ(static_cast<size_t>(Span.size()), Array.size());
std::array<const int, 3> ConstArray{0, 1, 2};
std::array<const int, 3> ConstArray{{0, 1, 2}};
acxxel::Span<const int> ConstSpan(ConstArray);
EXPECT_EQ(ConstSpan.data(), ConstArray.data());
EXPECT_EQ(static_cast<size_t>(ConstSpan.size()), ConstArray.size());