forked from OSchip/llvm-project
[lldb] Skip TestAppleSimulatorOSType if json parsing fails
xcodebuild, which is invoked by the apple_simulator_test decorator, may may return a successful status even if it was unable to run due to the authorization agent denying it. This causes the TestAppleSimulatorOSType to run when it shouldn't, and throw an excpection when parsing the JSON that lists the simulators available. Wrap the json parsing in a try/except block and if it fails, skip the ttest. Differential Revision: https://reviews.llvm.org/D109336
This commit is contained in:
parent
45a8608d7b
commit
47dd1f6428
|
@ -20,7 +20,16 @@ class TestAppleSimulatorOSType(gdbremote_testcase.GdbRemoteTestCaseBase):
|
|||
cmd = ['xcrun', 'simctl', 'list', '-j', 'devices']
|
||||
self.trace(' '.join(cmd))
|
||||
sim_devices_str = subprocess.check_output(cmd).decode("utf-8")
|
||||
sim_devices = json.loads(sim_devices_str)['devices']
|
||||
|
||||
# xcodebuild, which is invoked by the apple_simulator_test decorator,
|
||||
# may return a successful status even if it was unable to run due to
|
||||
# the authorization agent denying it. Try to parse the json that lists
|
||||
# the simulators but if that fails skip the test.
|
||||
try:
|
||||
sim_devices = json.loads(sim_devices_str)['devices']
|
||||
except json.decoder.JSONDecodeError:
|
||||
self.skipTest("Could not parse JSON of simulators available")
|
||||
|
||||
# Find an available simulator for the requested platform
|
||||
deviceUDID = None
|
||||
deviceRuntime = None
|
||||
|
|
Loading…
Reference in New Issue