Revert "[cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON"

This reverts commit df839cfda0.

This change used cmake's list filter operation which was not added
until cmake 3.6.
This commit is contained in:
Tom Stellard 2020-01-22 16:12:45 -08:00
parent df839cfda0
commit 4751e4f8c2
1 changed files with 1 additions and 9 deletions

View File

@ -14,17 +14,9 @@ foreach (lib ${clang_libs})
list(APPEND _OBJECTS $<TARGET_OBJECTS:obj.${lib}>)
endif()
list(APPEND _DEPS $<TARGET_PROPERTY:${lib},INTERFACE_LINK_LIBRARIES>)
get_target_property(interface ${lib} LINK_LIBRARIES)
if (interface)
list(APPEND _DEPS ${interface})
endif()
list(APPEND _DEPS $<TARGET_PROPERTY:${lib},LINK_LIBRARIES>)
endforeach ()
# clang libraries are redundant since we are linking all the individual
# object files into libclang-cpp.so, so filter them out from _DEPS.
# This avoids problems with LLVM global data when building with
# BUILD_SHARED_LIBS=ON
list(FILTER _DEPS EXCLUDE REGEX "^clang")
if (CLANG_LINK_CLANG_DYLIB)
set(INSTALL_WITH_TOOLCHAIN INSTALL_WITH_TOOLCHAIN)
endif()