maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[SCEV] Remove unnecessary call to forgetMemoizedResults 

`SCEVUnknown::allUsesReplacedWith` does not need to call `forgetMemoizedResults`
since RAUW does a value-equivalent replacement by assumption.  If this
assumption was false then the later setValPtr(New) call would be incorrect too.

This is a non-trivial performance optimization for functions with a large number
of loops since `forgetMemoizedResults` walks all loop backedge taken counts to
see if any of them use the SCEVUnknown being RAUWed.  However, this improvement
is difficult to demonstrate without checking in an excessively large IR file.

llvm-svn: 309072
This commit is contained in:
Sanjoy Das 2017-07-26 01:32:19 +00:00
parent 2345dbbd54
commit 469e740f2b
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
llvm/lib/Analysis/ScalarEvolution.cpp
View File

@ -415,9 +415,6 @@ void SCEVUnknown::deleted() {
} }
void SCEVUnknown::allUsesReplacedWith(Value *New) { void SCEVUnknown::allUsesReplacedWith(Value *New) {
// Clear this SCEVUnknown from various maps.
SE->forgetMemoizedResults(this);
// Remove this SCEVUnknown from the uniquing map. // Remove this SCEVUnknown from the uniquing map.
SE->UniqueSCEVs.RemoveNode(this); SE->UniqueSCEVs.RemoveNode(this);