From 4640a8a22cbae50c03c5f41d145916258a17a491 Mon Sep 17 00:00:00 2001 From: Peixin Qiao Date: Wed, 27 Jul 2022 23:37:55 +0800 Subject: [PATCH] [NFC][flang] Add FIXME for privatization of loop bounds in Bridge.cpp There is post comment of adding TODO/FIXME for privatization of loop bounds in D127137. D127137 fixes the bug in OpenMP firstprivate clause, which should be refactored later according to the post comment. Add FIXME for it. Differential Revision: https://reviews.llvm.org/D130625 --- flang/lib/Lower/Bridge.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/flang/lib/Lower/Bridge.cpp b/flang/lib/Lower/Bridge.cpp index 5a5cfe56be98..5d88d20f931a 100644 --- a/flang/lib/Lower/Bridge.cpp +++ b/flang/lib/Lower/Bridge.cpp @@ -478,6 +478,7 @@ public: // new copied value. // Not able to use replaceAllUsesWith() because uses outside // the loop body should not use the clone. + // FIXME: Call privatization before the loop operation. mlir::Region &curRegion = getFirOpBuilder().getRegion(); mlir::Value oldVal = fir::getBase(hexv); mlir::Value cloneVal = fir::getBase(exv);