maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

MC: make section classification a bit more thorough 

This does *NOT* change the emitted section flags in any way.  This only
impacts the internal classification of sections.

Extend the section classification in LLVM for ELF targets.  This has one
important change: we now classify sections as text by default rather
than readonly.  This matches the behaviour for GAS better.

Ensure that any section that has a writable attribute set is not treated
as readonly.  We also special case any section named `.debug_` which is
reserved for DWARF as metadata.  In the case none of the attributes are
set (or because no attributes were provided), consult the section name
for classification.  We match the well known names and classify the
section accordingly.  Any remaining section is now classified as text.

This change allows us to classify sections in the MC layer more
precisely which is needed for subsequent changes for handling target
specific behaviour.

Re-apply the change that was reverted with additional changes to
classify section prefixes appropriately and differentiate the TLS
sections, addressing the FIXME and post-commit review comments by
@MaskRay.

Differential Revision: https://reviews.llvm.org/D133456
Reviewed By: @MaskRay
This commit is contained in:
Saleem Abdulrasool 2022-08-05 16:52:03 +00:00
parent 4132bce9e5
commit 463da422f0
2 changed files with 45 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
llvm/lib/MC/MCContext.cpp
View File

@ -564,8 +564,37 @@ MCSectionELF *MCContext::getELFSection(const Twine &Section, unsigned Type,
Kind = SectionKind::getExecuteOnly();
else if (Flags & ELF::SHF_EXECINSTR)
Kind = SectionKind::getText();
else
else if (~Flags & ELF::SHF_WRITE)
Kind = SectionKind::getReadOnly();
else if (Flags & ELF::SHF_TLS)
Kind = (Type & ELF::SHT_NOBITS) ? SectionKind::getThreadBSS()
: SectionKind::getThreadData();
else
// Default to `SectionKind::getText()`. This is the default for gas as
// well. The condition that falls into this case is where we do not have any
// section flags and must infer a classification rather than where we have
// section flags (i.e. this is not that SHF_EXECINSTR is unset bur rather it
// is unknown).
Kind = llvm::StringSwitch<SectionKind>(CachedName)
.Case(".bss", SectionKind::getBSS())
.StartsWith(".bss.", SectionKind::getBSS())
.StartsWith(".gnu.linkonce.b.", SectionKind::getBSS())
.StartsWith(".llvm.linkonce.b.", SectionKind::getBSS())
.Case(".data", SectionKind::getData())
.Case(".data1", SectionKind::getData())
.Case(".data.rel.ro", SectionKind::getReadOnlyWithRel())
.Case(".rodata", SectionKind::getReadOnly())
.Case(".rodata1", SectionKind::getReadOnly())
.Case(".tbss", SectionKind::getThreadBSS())
.StartsWith(".tbss.", SectionKind::getThreadData())
.StartsWith(".gnu.linkonce.tb.", SectionKind::getThreadData())
.StartsWith(".llvm.linkonce.tb.", SectionKind::getThreadData())
.Case(".tdata", SectionKind::getThreadData())
.StartsWith(".tdata.", SectionKind::getThreadData())
.StartsWith(".gnu.linkonce.td.", SectionKind::getThreadData())
.StartsWith(".llvm.linkonce.td.", SectionKind::getThreadData())
.StartsWith(".debug_", SectionKind::getMetadata())
.Default(SectionKind::getText());
MCSectionELF *Result =
createELFSectionImpl(CachedName, Type, Flags, Kind, EntrySize, GroupSym,

15
llvm/test/MC/ELF/section-classification.ll Normal file
View File

@ -0,0 +1,15 @@
; We run this test explicitly converting from `.ll` to `.s` to `.o` to test the
; classification of the section and the incorrect handling for the padding flag.
; RUN: llc -filetype asm -o - %s | llvm-mc -triple x86_64-unknown-linux-gnu -filetype obj -o /dev/null -
; REQUIRES: asserts
target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
%struct.C = type { i32 }
$_ZZ6getRefvE8instance = comdat any
@_ZZ6getRefvE8instance = linkonce_odr dso_local global %struct.C zeroinitializer, comdat, align 4
@llvm.compiler.used = appending global [1 x ptr] [ptr @_ZZ6getRefvE8instance], section "llvm.metadata"