maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

compiler-rt: Try to appease lint script. 

A bot complains:

/b/sanitizer-x86_64-linux-autoconf/build/llvm/projects/compiler-rt/lib/sanitizer_common/tests/malloc_stress_transfer_test.cpp:2:  Streams are highly discouraged.  [readability/streams] [3]
/b/sanitizer-x86_64-linux-autoconf/build/llvm/projects/compiler-rt/lib/sanitizer_common/tests/sanitizer_libc_test.cpp:11:  Streams are highly discouraged.  [readability/streams] [3]
lib/CMakeFiles/SanitizerLintCheck.dir/build.make:57: recipe for target 'lib/CMakeFiles/SanitizerLintCheck' failed

I do not know why this apparently wasn't a problem when the files
had extension .cc.

llvm-svn: 367493
This commit is contained in:
Nico Weber 2019-07-31 23:34:07 +00:00
parent 89b80f1239
commit 45ff4868c4
2 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
compiler-rt/lib/sanitizer_common/tests/malloc_stress_transfer_test.cpp
View File

@ -1,5 +1,4 @@
#include <thread> #include <thread>
#include <iostream>
const size_t kAllocSize = 16; const size_t kAllocSize = 16;
const size_t kInitialNumAllocs = 1 << 10; const size_t kInitialNumAllocs = 1 << 10;
@ -8,8 +7,6 @@ const size_t kNumIterations = 1 << 7;
const size_t kNumThreads = 16; const size_t kNumThreads = 16;
void Thread() { void Thread() {
// int sp;
// std::cerr << "Thread starting, sp = " << &sp << std::endl;
char *InitialAllocations[kInitialNumAllocs]; char *InitialAllocations[kInitialNumAllocs];
char *PeriodicaAllocations[kPeriodicNumAllocs]; char *PeriodicaAllocations[kPeriodicNumAllocs];
for (auto &p : InitialAllocations) p = new char[kAllocSize]; for (auto &p : InitialAllocations) p = new char[kAllocSize];
@ -26,8 +23,6 @@ void Thread() {
} }
int main() { int main() {
// Thread();
// return 0;
std::thread *Threads[kNumThreads]; std::thread *Threads[kNumThreads];
for (auto &T : Threads) T = new std::thread(&Thread); for (auto &T : Threads) T = new std::thread(&Thread);
for (auto T : Threads) { for (auto T : Threads) {

11
compiler-rt/lib/sanitizer_common/tests/sanitizer_libc_test.cpp
View File

@ -8,7 +8,8 @@
// Tests for sanitizer_libc.h. // Tests for sanitizer_libc.h.
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#include <algorithm> #include <algorithm>
#include <fstream> #include <vector>
#include <stdio.h>
#include "sanitizer_common/sanitizer_common.h" #include "sanitizer_common/sanitizer_common.h"
#include "sanitizer_common/sanitizer_file.h" #include "sanitizer_common/sanitizer_file.h"
@ -173,9 +174,11 @@ class SanitizerCommonFileTest : public ::testing::TestWithParam<uptr> {
temp_file_name(file_name_, sizeof(file_name_), temp_file_name(file_name_, sizeof(file_name_),
"sanitizer_common.ReadFile.tmp."); "sanitizer_common.ReadFile.tmp.");
std::ofstream f(file_name_, std::ios::out | std::ios::binary); if (FILE *f = fopen(file_name_, "wb")) {
if (!data_.empty()) if (!data_.empty())
f.write(data_.data(), data_.size()); fwrite(data_.data(), data_.size(), 1, f);
fclose(f);
}
} }
void TearDown() override { Unlink(file_name_); } void TearDown() override { Unlink(file_name_); }