maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[NFC][CVP] Rename predicates - s/positive/non negative/ to better note that zero is ok

This commit is contained in:
Roman Lebedev 2020-07-18 13:13:01 +03:00
parent 2cde6984d8
commit 45b7388824
No known key found for this signature in database
GPG Key ID: 083C3EBB4A1689E0
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
llvm/lib/Transforms/Scalar/CorrelatedValuePropagation.cpp
View File

@ -601,15 +601,15 @@ static bool processCallSite(CallBase &CB, LazyValueInfo *LVI) {
return true;
}
static bool isPositive(Value *V, LazyValueInfo *LVI, Instruction *CxtI) {
static bool isNonNegative(Value *V, LazyValueInfo *LVI, Instruction *CxtI) {
Constant *Zero = ConstantInt::get(V->getType(), 0);
auto Result = LVI->getPredicateAt(ICmpInst::ICMP_SGE, V, Zero, CxtI);
return Result == LazyValueInfo::True;
}
static bool hasPositiveOperands(BinaryOperator *SDI, LazyValueInfo *LVI) {
static bool allOperandsAreNonNegative(BinaryOperator *SDI, LazyValueInfo *LVI) {
return all_of(SDI->operands(),
[&](Value *Op) { return isPositive(Op, LVI, SDI); });
[&](Value *Op) { return isNonNegative(Op, LVI, SDI); });
}
/// Try to shrink a udiv/urem's width down to the smallest power of two that's
@ -655,7 +655,7 @@ static bool processUDivOrURem(BinaryOperator *Instr, LazyValueInfo *LVI) {
}
static bool processSRem(BinaryOperator *SDI, LazyValueInfo *LVI) {
if (SDI->getType()->isVectorTy() || !hasPositiveOperands(SDI, LVI))
if (SDI->getType()->isVectorTy() || !allOperandsAreNonNegative(SDI, LVI))
return false;
++NumSRems;
@ -677,7 +677,7 @@ static bool processSRem(BinaryOperator *SDI, LazyValueInfo *LVI) {
/// conditions, this can sometimes prove conditions instcombine can't by
/// exploiting range information.
static bool processSDiv(BinaryOperator *SDI, LazyValueInfo *LVI) {
if (SDI->getType()->isVectorTy() || !hasPositiveOperands(SDI, LVI))
if (SDI->getType()->isVectorTy() || !allOperandsAreNonNegative(SDI, LVI))
return false;
++NumSDivs;
@ -698,7 +698,7 @@ static bool processAShr(BinaryOperator *SDI, LazyValueInfo *LVI) {
if (SDI->getType()->isVectorTy())
return false;
if (!isPositive(SDI->getOperand(0), LVI, SDI))
if (!isNonNegative(SDI->getOperand(0), LVI, SDI))
return false;
++NumAShrs;
@ -718,7 +718,7 @@ static bool processSExt(SExtInst *SDI, LazyValueInfo *LVI) {
Value *Base = SDI->getOperand(0);
if (!isPositive(Base, LVI, SDI))
if (!isNonNegative(Base, LVI, SDI))
return false;
++NumSExt;