maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

visitINSERT_VECTOR_ELT - pull out repeated dyn_cast. NFCI. 

This always gets called at least once.
This commit is contained in:
Simon Pilgrim 2020-02-05 12:32:25 +00:00
parent 564275289d
commit 4592bb7195
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
View File

@ -16900,11 +16900,11 @@ SDValue DAGCombiner::visitINSERT_VECTOR_ELT(SDNode *N) {
EVT VT = InVec.getValueType(); EVT VT = InVec.getValueType();
unsigned NumElts = VT.getVectorNumElements(); unsigned NumElts = VT.getVectorNumElements();
auto *IndexC = dyn_cast<ConstantSDNode>(EltNo);
// Insert into out-of-bounds element is undefined. // Insert into out-of-bounds element is undefined.
if (auto *IndexC = dyn_cast<ConstantSDNode>(EltNo)) if (IndexC && IndexC->getZExtValue() >= VT.getVectorNumElements())
if (IndexC->getZExtValue() >= VT.getVectorNumElements()) return DAG.getUNDEF(VT);
return DAG.getUNDEF(VT);
// Remove redundant insertions: // Remove redundant insertions:
// (insert_vector_elt x (extract_vector_elt x idx) idx) -> x // (insert_vector_elt x (extract_vector_elt x idx) idx) -> x
@ -16912,7 +16912,6 @@ SDValue DAGCombiner::visitINSERT_VECTOR_ELT(SDNode *N) {
InVec == InVal.getOperand(0) && EltNo == InVal.getOperand(1)) InVec == InVal.getOperand(0) && EltNo == InVal.getOperand(1))
return InVec; return InVec;
auto *IndexC = dyn_cast<ConstantSDNode>(EltNo);
if (!IndexC) { if (!IndexC) {
// If this is variable insert to undef vector, it might be better to splat: // If this is variable insert to undef vector, it might be better to splat:
// inselt undef, InVal, EltNo --> build_vector < InVal, InVal, ... > // inselt undef, InVal, EltNo --> build_vector < InVal, InVal, ... >