maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[MCA] Simplify the rounding logic used in TimelineView::printWaitTimeEntry. 

This is related to PR51392.

Before this patch, the timeline view was rounding doubles to the first decimal,
using a logic similar to this:

```
  double AverageTime = (double)Input / CumulativeExecutions;
  double Result = floor((AverageTime * 10) + 0.5) / 10
```

Here, Input and CumulativeExecutions are both unsigned integers.
The last operation is what effectively performs the rounding of AverageTime.

PR51392 has been raised because - under specific -m32 configurations of GCC -
one of the timeline tests reports slighlty different values (due to a different
rounding choice).

This patch tries to minimise the propagation of floating-point error by
hoisting the multiply by 10, so that it is performed on the unsigned.

```
  double AverageTime = (double)(Input * 10) / CumulativeExecutions;
  floor(AverageTime + 0.5) / 10
```

So we are trading a floating point multiply for a integer multiply (which can be
expanded using a simple MUL or using an `ADD + LEA` sequence). This decrease in
floating point operations executed should also help with decreasing the error in
the computation..

Strictly speaking, that computation will always be potentially subject to error
(depending on what values are passed in input). However, this patch should
improve the situation and make bug like PR51392 less frequent.
This commit is contained in:
Andrea Di Biagio 2021-08-07 11:39:33 +01:00
parent 454f69bcc1
commit 45685a1fc4
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
llvm/tools/llvm-mca/Views/TimelineView.cpp
View File

@ -145,10 +145,11 @@ void TimelineView::printWaitTimeEntry(formatted_raw_ostream &OS,
double AverageTime1, AverageTime2, AverageTime3;
AverageTime1 =
(double)Entry.CyclesSpentInSchedulerQueue / CumulativeExecutions;
AverageTime2 = (double)Entry.CyclesSpentInSQWhileReady / CumulativeExecutions;
AverageTime3 =
(double)Entry.CyclesSpentAfterWBAndBeforeRetire / CumulativeExecutions;
(double)(Entry.CyclesSpentInSchedulerQueue * 10) / CumulativeExecutions;
AverageTime2 =
(double)(Entry.CyclesSpentInSQWhileReady * 10) / CumulativeExecutions;
AverageTime3 = (double)(Entry.CyclesSpentAfterWBAndBeforeRetire * 10) /
CumulativeExecutions;
OS << Executions;
OS.PadToColumn(13);
@ -157,18 +158,18 @@ void TimelineView::printWaitTimeEntry(formatted_raw_ostream &OS,
if (!PrintingTotals)
tryChangeColor(OS, Entry.CyclesSpentInSchedulerQueue, CumulativeExecutions,
BufferSize);
OS << format("%.1f", floor((AverageTime1 * 10) + 0.5) / 10);
OS << format("%.1f", floor(AverageTime1 + 0.5) / 10);
OS.PadToColumn(20);
if (!PrintingTotals)
tryChangeColor(OS, Entry.CyclesSpentInSQWhileReady, CumulativeExecutions,
BufferSize);
OS << format("%.1f", floor((AverageTime2 * 10) + 0.5) / 10);
OS << format("%.1f", floor(AverageTime2 + 0.5) / 10);
OS.PadToColumn(27);
if (!PrintingTotals)
tryChangeColor(OS, Entry.CyclesSpentAfterWBAndBeforeRetire,
CumulativeExecutions,
getSubTargetInfo().getSchedModel().MicroOpBufferSize);
OS << format("%.1f", floor((AverageTime3 * 10) + 0.5) / 10);
OS << format("%.1f", floor(AverageTime3 + 0.5) / 10);
if (OS.has_colors())
OS.resetColor();