maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[LLDB][NFC] Fix incorrect return status Some functions always return 'false' for both success and fail return paths. 

Differential Revision: https://reviews.llvm.org/D131013
This commit is contained in:
Slava Gurevich 2022-08-02 11:54:52 -07:00
parent 6cbc6e9a6d
commit 4502e3531f
3 changed files with 10 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lldb/source/Plugins/Language/ObjC/NSArray.cpp
View File

@ -532,9 +532,8 @@ lldb_private::formatters::
process_sp->ReadMemory(data_location, m_data_64, sizeof(D64),
error);
}
if (error.Fail())
return false;
return false;
return error.Success();
}
bool
@ -675,9 +674,8 @@ lldb_private::formatters::GenericNSArrayISyntheticFrontEnd<D32, D64, Inline>::
process_sp->ReadMemory(data_location, m_data_64, sizeof(D64),
error);
}
if (error.Fail())
return false;
return false;
return error.Success();
}
template <typename D32, typename D64, bool Inline>

10
lldb/source/Plugins/Language/ObjC/NSDictionary.cpp
View File

@ -1121,9 +1121,8 @@ lldb_private::formatters::GenericNSDictionaryMSyntheticFrontEnd<D32,D64>::
process_sp->ReadMemory(data_location, m_data_64, sizeof(D64),
error);
}
if (error.Fail())
return false;
return true;
return error.Success();
}
template <typename D32, typename D64>
@ -1284,9 +1283,8 @@ lldb_private::formatters::Foundation1100::
process_sp->ReadMemory(data_location, m_data_64, sizeof(DataDescriptor_64),
error);
}
if (error.Fail())
return false;
return false;
return error.Success();
}
bool

6
lldb/source/Plugins/Language/ObjC/NSSet.cpp
View File

@ -461,7 +461,7 @@ bool lldb_private::formatters::NSSetISyntheticFrontEnd::Update() {
if (error.Fail())
return false;
m_data_ptr = data_location + m_ptr_size;
return false;
return true;
}
bool lldb_private::formatters::NSSetISyntheticFrontEnd::MightHaveChildren() {
@ -735,9 +735,7 @@ lldb_private::formatters::
process_sp->ReadMemory(data_location, m_data_64, sizeof(D64),
error);
}
if (error.Fail())
return false;
return false;
return error.Success();
}
template <typename D32, typename D64>