From 442b9a90a47450b446c08aaae844a95baa2b92e3 Mon Sep 17 00:00:00 2001 From: Benjamin Kramer Date: Sun, 29 May 2016 11:04:56 +0000 Subject: [PATCH] Avoid unnecessary std::string copies. NFC. llvm-svn: 271182 --- clang/lib/Frontend/CompilerInvocation.cpp | 2 +- clang/lib/Tooling/Refactoring.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/clang/lib/Frontend/CompilerInvocation.cpp b/clang/lib/Frontend/CompilerInvocation.cpp index 4bb08c8a81c1..42ce6df1329e 100644 --- a/clang/lib/Frontend/CompilerInvocation.cpp +++ b/clang/lib/Frontend/CompilerInvocation.cpp @@ -400,7 +400,7 @@ static void setPGOInstrumentor(CodeGenOptions &Opts, ArgList &Args, // Set the profile kind using fprofile-instrument-use-path. static void setPGOUseInstrumentor(CodeGenOptions &Opts, - const std::string ProfileName) { + const Twine &ProfileName) { auto ReaderOrErr = llvm::IndexedInstrProfReader::create(ProfileName); // In error, return silently and let Clang PGOUse report the error message. if (auto E = ReaderOrErr.takeError()) { diff --git a/clang/lib/Tooling/Refactoring.cpp b/clang/lib/Tooling/Refactoring.cpp index 3a1527558584..51f0635c1ecb 100644 --- a/clang/lib/Tooling/Refactoring.cpp +++ b/clang/lib/Tooling/Refactoring.cpp @@ -70,8 +70,8 @@ bool formatAndApplyAllReplacements(const Replacements &Replaces, auto FileToReplaces = groupReplacementsByFile(Replaces); bool Result = true; - for (auto &FileAndReplaces : FileToReplaces) { - const std::string FilePath = FileAndReplaces.first; + for (const auto &FileAndReplaces : FileToReplaces) { + const std::string &FilePath = FileAndReplaces.first; auto &CurReplaces = FileAndReplaces.second; const FileEntry *Entry = Files.getFile(FilePath);