maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[mlir][spirv] Add get() method to TargetEnvAttr taking raw values 

Also make the getResourceLimits() method more explicit about its return type.

Differential Revision: https://reviews.llvm.org/D75484
This commit is contained in:
Lei Zhang 2020-03-02 17:27:05 -05:00
parent 5891e7302f
commit 440ef33073
2 changed files with 27 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
mlir/include/mlir/Dialect/SPIRV/TargetAndABI.h
View File

@ -52,6 +52,9 @@ public:
using Base::Base;
/// Gets a TargetEnvAttr instance.
static TargetEnvAttr get(Version version, ArrayRef<Extension> extensions,
ArrayRef<Capability> capabilities,
DictionaryAttr limits);
static TargetEnvAttr get(IntegerAttr version, ArrayAttr extensions,
ArrayAttr capabilities, DictionaryAttr limits);
@ -86,7 +89,7 @@ public:
ArrayAttr getCapabilitiesAttr();
/// Returns the target resource limits.
DictionaryAttr getResourceLimits();
ResourceLimitsAttr getResourceLimits();
static bool kindof(unsigned kind) { return kind == AttrKind::TargetEnv; }

25
mlir/lib/Dialect/SPIRV/TargetAndABI.cpp
View File

@ -48,6 +48,27 @@ struct TargetEnvAttributeStorage : public AttributeStorage {
} // namespace spirv
} // namespace mlir
spirv::TargetEnvAttr spirv::TargetEnvAttr::get(
spirv::Version version, ArrayRef<spirv::Extension> extensions,
ArrayRef<spirv::Capability> capabilities, DictionaryAttr limits) {
Builder b(limits.getContext());
auto versionAttr = b.getI32IntegerAttr(static_cast<uint32_t>(version));
SmallVector<Attribute, 4> extAttrs;
extAttrs.reserve(extensions.size());
for (spirv::Extension ext : extensions)
extAttrs.push_back(b.getStringAttr(spirv::stringifyExtension(ext)));
SmallVector<Attribute, 4> capAttrs;
capAttrs.reserve(capabilities.size());
for (spirv::Capability cap : capabilities)
capAttrs.push_back(b.getI32IntegerAttr(static_cast<uint32_t>(cap)));
return get(versionAttr, b.getArrayAttr(extAttrs), b.getArrayAttr(capAttrs),
limits);
}
spirv::TargetEnvAttr spirv::TargetEnvAttr::get(IntegerAttr version,
ArrayAttr extensions,
ArrayAttr capabilities,
@ -98,8 +119,8 @@ ArrayAttr spirv::TargetEnvAttr::getCapabilitiesAttr() {
return getImpl()->capabilities.cast<ArrayAttr>();
}
DictionaryAttr spirv::TargetEnvAttr::getResourceLimits() {
return getImpl()->limits.cast<DictionaryAttr>();
spirv::ResourceLimitsAttr spirv::TargetEnvAttr::getResourceLimits() {
return getImpl()->limits.cast<spirv::ResourceLimitsAttr>();
}
LogicalResult spirv::TargetEnvAttr::verifyConstructionInvariants(