diff --git a/llvm/include/llvm/MC/MCObjectFileInfo.h b/llvm/include/llvm/MC/MCObjectFileInfo.h index 75294b5d7325..4d1715eccf5a 100644 --- a/llvm/include/llvm/MC/MCObjectFileInfo.h +++ b/llvm/include/llvm/MC/MCObjectFileInfo.h @@ -33,12 +33,6 @@ protected: /// weak_definition of constant 0 for an omitted EH frame. bool SupportsWeakOmittedEHFrame; - /// IsFunctionEHFrameSymbolPrivate - This flag is set to true if the - /// "EH_frame" symbol for EH information should be an assembler temporary (aka - /// private linkage, aka an L or .L label) or false if it should be a normal - /// non-.globl label. This defaults to true. - bool IsFunctionEHFrameSymbolPrivate; - /// SupportsCompactUnwindWithoutEHFrame - True if the target object file /// supports emitting a compact unwind section without an associated EH frame /// section. @@ -201,9 +195,6 @@ public: void InitMCObjectFileInfo(StringRef TT, Reloc::Model RM, CodeModel::Model CM, MCContext &ctx); - bool isFunctionEHFrameSymbolPrivate() const { - return IsFunctionEHFrameSymbolPrivate; - } bool getSupportsWeakOmittedEHFrame() const { return SupportsWeakOmittedEHFrame; } diff --git a/llvm/lib/MC/MCDwarf.cpp b/llvm/lib/MC/MCDwarf.cpp index c38eb045b949..8f348528cbbb 100644 --- a/llvm/lib/MC/MCDwarf.cpp +++ b/llvm/lib/MC/MCDwarf.cpp @@ -1459,13 +1459,6 @@ MCSymbol *FrameEmitterImpl::EmitFDE(MCObjectStreamer &streamer, const MCObjectFileInfo *MOFI = context.getObjectFileInfo(); bool verboseAsm = streamer.isVerboseAsm(); - if (IsEH && frame.Function && !MOFI->isFunctionEHFrameSymbolPrivate()) { - MCSymbol *EHSym = - context.GetOrCreateSymbol(frame.Function->getName() + Twine(".eh")); - streamer.EmitEHSymAttributes(frame.Function, EHSym); - streamer.EmitLabel(EHSym); - } - // Length const MCExpr *Length = MakeStartMinusEndExpr(streamer, *fdeStart, *fdeEnd, 0); if (verboseAsm) streamer.AddComment("FDE Length"); diff --git a/llvm/lib/MC/MCObjectFileInfo.cpp b/llvm/lib/MC/MCObjectFileInfo.cpp index b9ba011a6731..b602656e0e39 100644 --- a/llvm/lib/MC/MCObjectFileInfo.cpp +++ b/llvm/lib/MC/MCObjectFileInfo.cpp @@ -41,7 +41,6 @@ static bool useCompactUnwind(const Triple &T) { void MCObjectFileInfo::InitMachOMCObjectFileInfo(Triple T) { // MachO - IsFunctionEHFrameSymbolPrivate = false; SupportsWeakOmittedEHFrame = false; if (T.isOSDarwin() && @@ -802,7 +801,6 @@ void MCObjectFileInfo::InitMCObjectFileInfo(StringRef T, Reloc::Model relocm, // Common. CommDirectiveSupportsAlignment = true; SupportsWeakOmittedEHFrame = true; - IsFunctionEHFrameSymbolPrivate = true; SupportsCompactUnwindWithoutEHFrame = false; PersonalityEncoding = LSDAEncoding = FDECFIEncoding = TTypeEncoding = diff --git a/llvm/test/MC/MachO/eh-frame-reloc.s b/llvm/test/MC/MachO/eh-frame-reloc.s index 66ff571eac89..4b2822404de9 100644 --- a/llvm/test/MC/MachO/eh-frame-reloc.s +++ b/llvm/test/MC/MachO/eh-frame-reloc.s @@ -24,7 +24,7 @@ _bar: // OLD64: Relocations [ // OLD64-NEXT: Section __eh_frame { -// OLD64-NEXT: 0x20 0 3 1 X86_64_RELOC_SUBTRACTOR 0 _bar.eh +// OLD64-NEXT: 0x20 0 3 0 X86_64_RELOC_SUBTRACTOR 0 // OLD64-NEXT: 0x20 0 3 1 X86_64_RELOC_UNSIGNED 0 _bar // OLD64-NEXT: } // OLD64-NEXT: ] diff --git a/llvm/test/MC/MachO/eh-symbols.s b/llvm/test/MC/MachO/eh-symbols.s deleted file mode 100644 index 6adca56cdbe7..000000000000 --- a/llvm/test/MC/MachO/eh-symbols.s +++ /dev/null @@ -1,25 +0,0 @@ -// RUN: llvm-mc -filetype=obj -triple i686-apple-darwin %s -o - | llvm-readobj -t | FileCheck %s - -// Make sure that the exception handling data has the same visibility as the -// function it's generated for. - - .private_extern _main - .globl _main -_main: - .cfi_startproc - retl - .cfi_endproc - -"_-[NSString(local) isNullOrNil]": - .cfi_startproc - retl - .cfi_endproc - -// CHECK: Name: _-[NSString(local) isNullOrNil].eh - -// CHECK: Name: _main -// CHECK-NEXT: PrivateExtern - -// CHECK: Name: _main.eh -// CHECK-NEXT: PrivateExtern -