maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

verify C99 6.7.5.3p2 

llvm-svn: 39219
This commit is contained in:
Chris Lattner 2006-11-28 04:05:37 +00:00
parent 652c16924e
commit 43e956c3b7
2 changed files with 29 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
clang/Parse/ParseDecl.cpp
View File

@ -908,12 +908,6 @@ void Parser::ParseParenDeclarator(Declarator &D) {
// Okay, this is the parameter list of a function definition, or it is an
// identifier list of a K&R-style function.
// TODO: enter function-declaration scope, limiting any declarators for
// arguments to the function scope.
// NOTE: better to only create a scope if not '()'
bool IsVariadic;
bool HasPrototype;
bool IsEmpty = false;
@ -955,9 +949,14 @@ void Parser::ParseParenDeclarator(Declarator &D) {
IsVariadic = false;
HasPrototype = false;
} else {
// Finally, a normal, non-empty parameter type list.
// Enter function-declaration scope, limiting any declarators for arguments
// to the function scope.
EnterScope(0);
IsVariadic = false;
bool ReadArg = false;
// Finally, a normal, non-empty parameter type list.
while (1) {
if (Tok.getKind() == tok::ellipsis) {
IsVariadic = true;
@ -990,7 +989,24 @@ void Parser::ParseParenDeclarator(Declarator &D) {
if (Tok.getKind() == tok::kw___attribute)
ParseAttributes();
// TODO: do something with the declarator, if it is valid.
// Verify C99 6.7.5.3p2: The only SCS allowed is 'register'.
switch (DS.StorageClassSpec) {
case DeclSpec::SCS_unspecified:
case DeclSpec::SCS_register:
break;
case DeclSpec::SCS_auto:
// NOTE: we could trivially allow 'int foo(auto int X)' if we wanted.
default:
// FIXME: Get better loc info from declspecs!
Diag(DeclaratorInfo.getIdentifierLoc(),
diag::err_invalid_storage_class_in_func_decl);
DS.StorageClassSpec = DeclSpec::SCS_unspecified;
break;
}
// Inform the actions module about the parameter declarator, so it gets
// added to the current scope.
Actions.ParseDeclarator(CurScope, DeclaratorInfo, 0, 0);
// If the next token is a comma, consume it and keep reading arguments.
if (Tok.getKind() != tok::comma) break;
@ -1000,9 +1016,10 @@ void Parser::ParseParenDeclarator(Declarator &D) {
}
HasPrototype = true;
}
// TODO: pop the scope.
// Leave prototype scope.
ExitScope();
}
// TODO: capture argument info.

2
clang/include/clang/Basic/DiagnosticKinds.def
View File

@ -390,6 +390,8 @@ DIAG(err_ellipsis_first_arg, ERROR,
"ISO C requires a named argument before '...'")
DIAG(err_unspecified_vla_size_with_static, ERROR,
"'static' may not be used with an unspecified variable length array size")
DIAG(err_invalid_storage_class_in_func_decl, ERROR,
"invalid storage class specifier in function declarator")
DIAG(err_unexpected_typedef, ERROR,
"unexpected type name '%s': expected expression")