From 43638a87e54406947ead673406a0362152a7126c Mon Sep 17 00:00:00 2001 From: Ted Kremenek Date: Fri, 22 Feb 2008 18:41:59 +0000 Subject: [PATCH] Punt on unifying symbolic lvalues. This won't be needed for many checkers. llvm-svn: 47489 --- clang/Analysis/GRSimpleVals.cpp | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/clang/Analysis/GRSimpleVals.cpp b/clang/Analysis/GRSimpleVals.cpp index 775d099ab79c..04a13e370351 100644 --- a/clang/Analysis/GRSimpleVals.cpp +++ b/clang/Analysis/GRSimpleVals.cpp @@ -225,11 +225,12 @@ RVal GRSimpleVals::EvalEQ(ValueManager& ValMgr, LVal L, LVal R) { return nonlval::SymIntConstraintVal(C); } - // FIXME: Implement unification - return UnknownVal(); - //assert (!isa(R) && "FIXME: Implement unification."); - - break; + // FIXME: Implement == for lval Symbols. This is mainly useful + // in iterator loops when traversing a buffer, e.g. while(z != zTerm). + // Since this is not useful for many checkers we'll punt on this for + // now. + + return UnknownVal(); } case lval::DeclValKind: @@ -278,7 +279,12 @@ RVal GRSimpleVals::EvalNE(ValueManager& ValMgr, LVal L, LVal R) { return nonlval::SymIntConstraintVal(C); } - assert (!isa(R) && "FIXME: Implement sym !=."); + // FIXME: Implement != for lval Symbols. This is mainly useful + // in iterator loops when traversing a buffer, e.g. while(z != zTerm). + // Since this is not useful for many checkers we'll punt on this for + // now. + + return UnknownVal(); break; }