maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[X86][clang] Enable floating-point type for -mno-x87 option on 32-bits 

We should match GCC's behavior which allows floating-point type for -mno-x87 option on 32-bits. https://godbolt.org/z/KrbhfWc9o

The previous block issues have partially been fixed by D112143.

Reviewed By: asavonic, nickdesaulniers

Differential Revision: https://reviews.llvm.org/D114162
This commit is contained in:
Phoebe Wang 2021-11-30 13:19:20 +08:00
parent a88bb5b9fe
commit 42c15c7edf
2 changed files with 5 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
clang/lib/Basic/Targets/X86.cpp
View File

@ -382,12 +382,10 @@ bool X86TargetInfo::handleTargetFeatures(std::vector<std::string> &Features,
SimdDefaultAlign =
hasFeature("avx512f") ? 512 : hasFeature("avx") ? 256 : 128;
if (!HasX87) {
if (LongDoubleFormat == &llvm::APFloat::x87DoubleExtended())
HasLongDouble = false;
if (getTriple().getArch() == llvm::Triple::x86)
HasFPReturn = false;
}
// FIXME: We should allow long double type on 32-bits to match with GCC.
// This requires backend to be able to lower f80 without x87 first.
if (!HasX87 && LongDoubleFormat == &llvm::APFloat::x87DoubleExtended())
HasLongDouble = false;
return true;
}

22
clang/test/Sema/x86-no-x87.cpp
View File

@ -1,4 +1,4 @@
// RUN: %clang_cc1 -fsyntax-only -verify %s -triple i686-linux-gnu -target-feature -x87 -DRET_ERROR
// RUN: %clang_cc1 -fsyntax-only -verify %s -triple i686-linux-gnu -target-feature -x87
// RUN: %clang_cc1 -fsyntax-only -verify %s -triple i686-linux-gnu -DNOERROR
#ifdef NOERROR
@ -123,42 +123,22 @@ void assign5() {
long_double ld = 0.42;
}
#ifndef NOERROR
// expected-note@+3{{'d_ret1' defined here}}
// expected-error@+2{{'d_ret1' requires 'double' return type support, but target 'i686-unknown-linux-gnu' does not support it}}
#endif
double d_ret1(float x) {
return 0.0;
}
#ifndef NOERROR
// expected-note@+2{{'d_ret2' defined here}}
#endif
double d_ret2(float x);
int d_ret3(float x) {
#ifndef NOERROR
// expected-error@+2{{'d_ret2' requires 'double' return type support, but target 'i686-unknown-linux-gnu' does not support it}}
#endif
return (int)d_ret2(x);
}
#ifndef NOERROR
// expected-note@+3{{'f_ret1' defined here}}
// expected-error@+2{{'f_ret1' requires 'float' return type support, but target 'i686-unknown-linux-gnu' does not support it}}
#endif
float f_ret1(float x) {
return 0.0f;
}
#ifndef NOERROR
// expected-note@+2{{'f_ret2' defined here}}
#endif
float f_ret2(float x);
int f_ret3(float x) {
#ifndef NOERROR
// expected-error@+2{{'f_ret2' requires 'float' return type support, but target 'i686-unknown-linux-gnu' does not support it}}
#endif
return (int)f_ret2(x);
}