maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[SplitModule] In split module utility we should never separate alias with its aliasee. 

Summary: When splitting module with preserving locals, we currently do not handle case of global alias being separated with its aliasee.

Subscribers: llvm-commits

Differential Revision: http://reviews.llvm.org/D16585

llvm-svn: 259075
This commit is contained in:
Sergei Larin 2016-01-28 18:59:28 +00:00
parent bff6b581e2
commit 427f570ce1
3 changed files with 92 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
llvm/lib/Transforms/Utils/SplitModule.cpp
View File

@ -88,6 +88,13 @@ static void findPartitions(Module *M, ClusterIDMapType &ClusterIDMap,
Member = &GV;
}
// For aliases we should not separate them from their aliasees regardless
// of linkage.
if (GlobalAlias *GA = dyn_cast<GlobalAlias>(&GV)) {
if (const GlobalObject *Base = GA->getBaseObject())
GVtoClusterMap.unionSets(&GV, Base);
}
// Further only iterate over local GVs.
if (!GV.hasLocalLinkage())
return;

38
llvm/test/tools/llvm-split/scc-const-alias.ll Executable file
View File

@ -0,0 +1,38 @@
; We should never separate alias from aliasee.
; RUN: llvm-split -j=3 -preserve-locals -o %t %s
; RUN: llvm-dis -o - %t0 | FileCheck --check-prefix=CHECK0 %s
; RUN: llvm-dis -o - %t1 | FileCheck --check-prefix=CHECK1 %s
; RUN: llvm-dis -o - %t2 | FileCheck --check-prefix=CHECK2 %s
; Checks are not critical here - verifier will assert if we fail.
; CHECK0: @g1 = global i32 99
; CHECK0: @c1Alias = external global i8
; CHECK0: @g1Alias = internal alias i8, bitcast (i32* @g1 to i8*)
; CHECK1: @g1 = external global i32
; CHECK1: @c1Alias = internal alias i8, inttoptr (i64 42 to i8*)
; Third file is actually empty.
; CHECK2: @g1 = external global i32
; CHECK2: @g1Alias = external global i8
; CHECK2: @c1Alias = external global i8
@g1 = global i32 99
@g1Alias = internal alias i8, bitcast (i32* @g1 to i8*)
@c1Alias = internal alias i8, inttoptr (i64 42 to i8*)
@funExternalAlias = alias i8 (), i8 ()* @funExternal
define i8 @funExternal() {
entry:
%x = load i8, i8* @g1Alias
ret i8 %x
}
define i8 @funExternal2() {
entry:
%x = load i8, i8* @c1Alias
%y = call i8 @funExternalAlias()
%z = add i8 %x, %y
ret i8 %z
}

47
llvm/test/tools/llvm-split/scc-global-alias.ll Normal file
View File

@ -0,0 +1,47 @@
; We should never separate alias from aliasee.
; RUN: llvm-split -j=3 -preserve-locals -o %t %s
; RUN: llvm-dis -o - %t0 | FileCheck --check-prefix=CHECK0 %s
; RUN: llvm-dis -o - %t1 | FileCheck --check-prefix=CHECK1 %s
; RUN: llvm-dis -o - %t2 | FileCheck --check-prefix=CHECK2 %s
; Checks are not critical here - verifier will assert if we fail.
; CHECK0: @funInternal2Alias = alias
; CHECK0: @funExternal2Alias = alias
; CHECK0: define internal i32 @funInternal2
; CHECK0: define i32 @funExternal2
; CHECK1: @funInternalAlias = alias
; CHECK1: define internal i32 @funInternal
; CHECK2: @funExternalAlias = alias
; CHECK2: define i32 @funExternal
@funInternalAlias = alias i32 (), i32 ()* @funInternal
@funExternalAlias = alias i32 (), i32 ()* @funExternal
@funInternal2Alias = alias i32 (), i32 ()* @funInternal2
@funExternal2Alias = alias i32 (), i32 ()* @funExternal2
define internal i32 @funInternal() {
entry:
ret i32 0
}
define i32 @funExternal() {
entry:
%x = call i32 @funInternalAlias()
ret i32 %x
}
define internal i32 @funInternal2() {
entry:
%x = call i32 @funInternalAlias()
ret i32 %x
}
define i32 @funExternal2() {
entry:
%x = call i32 @funInternal2()
%y = call i32 @funExternalAlias()
%z = add nsw i32 %x, %y
ret i32 %z
}