maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

implement some sema for gnuc_inline attribute. Reject always_inline and no_inline on objc methods. 

llvm-svn: 69051
This commit is contained in:
Chris Lattner 2009-04-14 17:02:11 +00:00
parent a5d077df73
commit 4225e23e62
3 changed files with 29 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
clang/include/clang/Basic/DiagnosticSemaKinds.td
View File

@ -398,6 +398,11 @@ def warn_attribute_weak_import_invalid_on_definition : Warning<
def warn_attribute_wrong_decl_type : Warning<
"'%0' attribute only applies to %select{function|union|"
"variable and function|function or method}1 types">;
def warn_gnuc_inline_attribute_requires_inline : Warning<
"'gnuc_inline' attribute requires function to be marked 'inline',"
" attribute ignored">;
def warn_gnuc_inline_attribute_extern_inline : Warning<
"'gnuc_inline' attribute is overridden by 'extern inline', attribute ignored">;
def warn_attribute_ignored_for_field_of_type : Warning<
"%0 attribute ignored for field of type %1">;

20
clang/lib/Sema/SemaDeclAttr.cpp
View File

@ -391,7 +391,7 @@ static void HandleAlwaysInlineAttr(Decl *d, const AttributeList &Attr,
return;
}
if (!isFunctionOrMethod(d)) {
if (!isa<FunctionDecl>(d)) {
S.Diag(Attr.getLoc(), diag::warn_attribute_wrong_decl_type)
<< "always_inline" << 0 /*function*/;
return;
@ -485,8 +485,7 @@ static void HandleConstructorAttr(Decl *d, const AttributeList &Attr, Sema &S) {
priority = Idx.getZExtValue();
}
FunctionDecl *Fn = dyn_cast<FunctionDecl>(d);
if (!Fn) {
if (!isa<FunctionDecl>(d)) {
S.Diag(Attr.getLoc(), diag::warn_attribute_wrong_decl_type)
<< "constructor" << 0 /*function*/;
return;
@ -1447,7 +1446,7 @@ static void HandleNoinlineAttr(Decl *d, const AttributeList &Attr, Sema &S) {
return;
}
if (!isFunctionOrMethod(d)) {
if (!isa<FunctionDecl>(d)) {
S.Diag(Attr.getLoc(), diag::warn_attribute_wrong_decl_type)
<< "noinline" << 0 /*function*/;
return;
@ -1463,12 +1462,23 @@ static void HandleGNUCInlineAttr(Decl *d, const AttributeList &Attr, Sema &S) {
return;
}
if (!isFunctionOrMethod(d)) {
FunctionDecl *Fn = dyn_cast<FunctionDecl>(d);
if (Fn == 0) {
S.Diag(Attr.getLoc(), diag::warn_attribute_wrong_decl_type)
<< "gnuc_inline" << 0 /*function*/;
return;
}
if (!Fn->isInline()) {
S.Diag(Attr.getLoc(), diag::warn_gnuc_inline_attribute_requires_inline);
return;
}
if (Fn->getStorageClass() == FunctionDecl::Extern) {
S.Diag(Attr.getLoc(), diag::warn_gnuc_inline_attribute_extern_inline);
return;
}
d->addAttr(::new (S.Context) GNUCInlineAttr());
}

9
clang/test/Sema/function.c
View File

@ -61,3 +61,12 @@ void f1static() {
struct incomplete_test a(void) {} // expected-error{{incomplete result type 'struct incomplete_test' in function definition}} \
// expected-note{{forward declaration of 'struct incomplete_test'}}
extern __inline
__attribute__((__gnuc_inline__)) // expected-warning{{'gnuc_inline' attribute is overridden by 'extern inline', attribute ignored}} expected-warning{{extension used}}
void gnu_inline1() {}
void
__attribute__((__gnuc_inline__)) // expected-warning {{'gnuc_inline' attribute requires function to be marked 'inline', attribute ignored}} expected-warning{{extension used}}
gnu_inline2() {}