maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[clangd] Stop logging in fromJSON, report instead.

This commit is contained in:
Sam McCall 2020-10-09 16:08:44 +02:00
parent d91234b21c
commit 41d2987c75
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
clang-tools-extra/clangd/Protocol.cpp
View File

@ -851,7 +851,7 @@ static llvm::StringRef toTextKind(MarkupKind Kind) {
bool fromJSON(const llvm::json::Value &V, MarkupKind &K, llvm::json::Path P) {
auto Str = V.getAsString();
if (!Str) {
elog("Failed to parse markup kind: expected a string");
P.report("expected string");
return false;
}
if (*Str == "plaintext")
@ -859,7 +859,7 @@ bool fromJSON(const llvm::json::Value &V, MarkupKind &K, llvm::json::Path P) {
else if (*Str == "markdown")
K = MarkupKind::Markdown;
else {
elog("Unknown markup kind: {0}", *Str);
P.report("unknown markup kind");
return false;
}
return true;