maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[DeadArgElim] Check that function type is the same 

If the function types differ, the call arguments don't necessarily
correspon to the function arguments. It's likely not worthwhile to
handle this more precisely, but at least we shouldn't crash.
This commit is contained in:
Nikita Popov 2022-02-14 14:07:22 +01:00
parent c72fdad71b
commit 41c5a762e5
2 changed files with 25 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
llvm/lib/Transforms/IPO/DeadArgumentElimination.cpp
View File

@ -306,7 +306,8 @@ bool DeadArgumentEliminationPass::RemoveDeadArgumentsFromCallers(Function &Fn) {
for (Use &U : Fn.uses()) {
CallBase *CB = dyn_cast<CallBase>(U.getUser());
if (!CB || !CB->isCallee(&U))
if (!CB || !CB->isCallee(&U) ||
CB->getFunctionType() != Fn.getFunctionType())
continue;
// Now go through all unused args and replace them with "undef".

23
llvm/test/Transforms/DeadArgElim/opaque-ptr.ll Normal file
View File

@ -0,0 +1,23 @@
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --function-signature
; RUN: opt -S -passes=deadargelim -opaque-pointers < %s | FileCheck %s
define void @callee(i32 %unused) {
; CHECK-LABEL: define {{[^@]+}}@callee
; CHECK-SAME: (i32 [[UNUSED:%.*]]) {
; CHECK-NEXT: ret void
;
ret void
}
define void @caller() {
; CHECK-LABEL: define {{[^@]+}}@caller() {
; CHECK-NEXT: call void @callee(i32 undef)
; CHECK-NEXT: call void @callee()
; CHECK-NEXT: call void @callee(i32 42, i32 24)
; CHECK-NEXT: ret void
;
call void @callee(i32 42)
call void @callee()
call void @callee(i32 42, i32 24)
ret void
}