Use a cheaper test, delaying calling find_leader() until we know that it's necessary. This improves

the time to optimize Anton's testcase from 21.1s to 17.6s.

llvm-svn: 38479
This commit is contained in:
Owen Anderson 2007-07-10 00:09:25 +00:00
parent 57111e7a60
commit 41c2cab873
1 changed files with 5 additions and 3 deletions

View File

@ -565,6 +565,7 @@ class ValueNumberedSet {
bool insert(Value* v) { return contents.insert(v); }
void insert(iterator I, iterator E) { contents.insert(I, E); }
void erase(Value* v) { contents.erase(v); }
unsigned count(Value* v) { return contents.count(v); }
size_t size() { return contents.size(); }
void set(unsigned i) {
@ -1173,15 +1174,16 @@ bool GVNPRE::elimination() {
isa<ShuffleVectorInst>(BI) || isa<InsertElementInst>(BI) ||
isa<ExtractElementInst>(BI) || isa<SelectInst>(BI) ||
isa<CastInst>(BI) || isa<GetElementPtrInst>(BI)) {
Value *leader = find_leader(availableOut[BB], VN.lookup(BI));
if (leader != 0)
if (availableOut[BB].test(VN.lookup(BI)) && ! availableOut[BB].count(BI)) {
Value *leader = find_leader(availableOut[BB], VN.lookup(BI));
if (Instruction* Instr = dyn_cast<Instruction>(leader))
if (Instr->getParent() != 0 && Instr != BI) {
replace.push_back(std::make_pair(BI, leader));
erase.push_back(BI);
++NumEliminated;
}
}
}
}
}