maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Work around dllimport bug with exclude_from_explicit_instantiation. 

When dllimport is specified on a class, and
exclude_from_explicit_instatiation is specified on a member, clang-cl
will still expect a definition to be available externally. But this is
not correct.

Surprisingly one one symbol seems to be consistently affected by this
bug. So this patch simply works around it there.

llvm-svn: 355760
This commit is contained in:
Eric Fiselier 2019-03-08 23:59:29 +00:00
parent 98214347c4
commit 411210838d
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
libcxx/include/__locale
View File

@ -254,7 +254,10 @@ public:
return do_compare(__lo1, __hi1, __lo2, __hi2); return do_compare(__lo1, __hi1, __lo2, __hi2);
} }
// FIXME(EricWF): The _LIBCPP_ALWAYS_INLINE is needed on Windows to work
// around a dllimport bug that expects an external instantiation.
_LIBCPP_INLINE_VISIBILITY _LIBCPP_INLINE_VISIBILITY
_LIBCPP_ALWAYS_INLINE
string_type transform(const char_type* __lo, const char_type* __hi) const string_type transform(const char_type* __lo, const char_type* __hi) const
{ {
return do_transform(__lo, __hi); return do_transform(__lo, __hi);