maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[libomptarget][amdgpu] use --allow-shlib-undefined to link on FreeBSD 

On FreeBSD, the `environ` symbol is undefined at link time for shared
libraries, but resolved by the dynamic linker at runtime. Therefore,
allow the symbol to be undefined when creating a shared library, by
using the `--allow-shlib-undefined` linker flag, instead of `-z defs`
(a.k.a `--no-undefined`).

Reviewed By: JonChesterfield

Differential Revision: https://reviews.llvm.org/D107698
This commit is contained in:
Dimitry Andric 2021-08-07 21:39:11 +02:00
parent ab4b4684a2
commit 400cd6d2f0
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
openmp/libomptarget/plugins/amdgpu/CMakeLists.txt
View File

@ -78,6 +78,15 @@ add_library(omptarget.rtl.amdgpu SHARED
# When we build for debug, OPENMP_LIBDIR_SUFFIX get set to -debug
install(TARGETS omptarget.rtl.amdgpu LIBRARY DESTINATION "lib${OPENMP_LIBDIR_SUFFIX}")
if(CMAKE_SYSTEM_NAME MATCHES "FreeBSD")
# On FreeBSD, the 'environ' symbol is undefined at link time, but resolved by
# the dynamic linker at runtime. Therefore, allow the symbol to be undefined
# when creating a shared library.
set(LDFLAGS_UNDEFINED "-Wl,--allow-shlib-undefined")
else()
set(LDFLAGS_UNDEFINED "-Wl,-z,defs")
endif()
set_property(TARGET omptarget.rtl.amdgpu PROPERTY INSTALL_RPATH "$ORIGIN")
target_link_libraries(
omptarget.rtl.amdgpu
@ -88,7 +97,7 @@ target_link_libraries(
${LIBOMPTARGET_DEP_LIBELF_LIBRARIES}
${OPENMP_PTHREAD_LIB}
"-Wl,--version-script=${CMAKE_CURRENT_SOURCE_DIR}/../exports"
"-Wl,-z,defs"
${LDFLAGS_UNDEFINED}
)
if (LLVM_BINARY_DIR)