maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[ELF] Replace a dead test in getSymVA() with assert() 

Symbols relative to discarded comdat sections are Undefined instead of
Defined now (after D59649 and D61583). The `== &InputSection::Discarded`
test becomes dead. I cannot find a test related to this behavior.

Reviewed By: ruiu

Differential Revision: https://reviews.llvm.org/D62725

llvm-svn: 362218
This commit is contained in:
Fangrui Song 2019-05-31 10:12:22 +00:00
parent 39390d8317
commit 3f29cfd915
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lld/ELF/Symbols.cpp
View File

@ -47,17 +47,11 @@ static uint64_t getSymVA(const Symbol &Sym, int64_t &Addend) {
auto &D = cast<Defined>(Sym);
SectionBase *IS = D.Section;
// According to the ELF spec reference to a local symbol from outside
// the group are not allowed. Unfortunately .eh_frame breaks that rule
// and must be treated specially. For now we just replace the symbol with
// 0.
if (IS == &InputSection::Discarded)
return 0;
// This is an absolute symbol.
if (!IS)
return D.Value;
assert(IS != &InputSection::Discarded);
IS = IS->Repl;
uint64_t Offset = D.Value;