maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[flang] Address review comment 

Original-commit: flang-compiler/f18@d6964fdd9f
Reviewed-on: https://github.com/flang-compiler/f18/pull/488
This commit is contained in:
peter klausler 2019-06-07 12:00:32 -07:00
parent fc61632c21
commit 3e92bb77aa
1 changed files with 3 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
flang/lib/evaluate/tools.h
View File

@ -76,11 +76,7 @@ template<typename T> bool IsVariable(const Expr<T> &expr) {
return std::visit([](const auto &x) { return IsVariable(x); }, expr.u);
}
template<typename A> bool IsVariable(const std::optional<A> &x) {
if (x.has_value()) {
return IsVariable(*x);
} else {
return false;
}
return x.has_value() && IsVariable(*x);
}
// Predicate: true when an expression is assumed-rank
@ -99,11 +95,7 @@ template<typename T> bool IsAssumedRank(const Expr<T> &expr) {
return std::visit([](const auto &x) { return IsAssumedRank(x); }, expr.u);
}
template<typename A> bool IsAssumedRank(const std::optional<A> &x) {
if (x.has_value()) {
return IsAssumedRank(*x);
} else {
return false;
}
return x.has_value() && IsAssumedRank(*x);
}
// Generalizing packagers: these take operations and expressions of more
@ -667,11 +659,7 @@ inline bool IsProcedurePointer(const Expr<SomeType> &expr) {
[](const auto &x) { return IsProcedurePointer(x); }, expr.u);
}
template<typename A> bool IsProcedurePointer(const std::optional<A> &x) {
if (x.has_value()) {
return IsProcedurePointer(*x);
} else {
return false;
}
return x.has_value() && IsProcedurePointer(*x);
}
}
#endif // FORTRAN_EVALUATE_TOOLS_H_