maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[AIX] Also error on -G for link-only step 

Error on -G on AIX for all modes(preprocess, assemble, compile, link).

Differential Revision: https://reviews.llvm.org/D90063
This commit is contained in:
Xiangling Liao 2020-10-26 16:23:30 -04:00
parent 5a6e66ec72
commit 3d4aebbb9d
3 changed files with 30 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
clang/lib/Driver/Driver.cpp
View File

@ -3888,9 +3888,15 @@ void Driver::BuildJobs(Compilation &C) const {
}
}
const llvm::Triple &RawTriple = C.getDefaultToolChain().getTriple();
if (RawTriple.isOSAIX())
if (Arg *A = C.getArgs().getLastArg(options::OPT_G))
Diag(diag::err_drv_unsupported_opt_for_target)
<< A->getSpelling() << RawTriple.str();
// Collect the list of architectures.
llvm::StringSet<> ArchNames;
if (C.getDefaultToolChain().getTriple().isOSBinFormatMachO())
if (RawTriple.isOSBinFormatMachO())
for (const Arg *A : C.getArgs())
if (A->getOption().matches(options::OPT_arch))
ArchNames.insert(A->getValue());

5
clang/lib/Driver/ToolChains/Clang.cpp
View File

@ -4958,11 +4958,6 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA,
if (D.CCGenDiagnostics)
CmdArgs.push_back("-disable-pragma-debug-crash");
if (RawTriple.isOSAIX())
if (Arg *A = Args.getLastArg(options::OPT_G))
D.Diag(diag::err_drv_unsupported_opt_for_target)
<< A->getSpelling() << RawTriple.str();
bool UseSeparateSections = isUseSeparateSections(Triple);
if (Args.hasFlag(options::OPT_ffunction_sections,

25
clang/test/Driver/aix-err-options.c
View File

@ -1,7 +1,28 @@
// RUN: %clang -target powerpc32-ibm-aix-xcoff -### -S -emit-llvm -G 0 2>&1 %s | \
// RUN: %clang -target powerpc-ibm-aix-xcoff -### -E -G 0 2>&1 %s | \
// RUN: FileCheck --check-prefix=CHECK32 %s
// RUN: %clang -target powerpc-ibm-aix-xcoff -### -S -emit-llvm -G 0 2>&1 %s | \
// RUN: FileCheck --check-prefix=CHECK32 %s
// RUN: %clang -target powerpc-ibm-aix-xcoff -### -c -G 0 2>&1 %s | \
// RUN: FileCheck --check-prefix=CHECK32 %s
// RUN: %clang -target powerpc-ibm-aix-xcoff -### -c \
// RUN: %S/Inputs/aix_ppc_tree/dummy0.s -G 0 2>&1 | \
// RUN: FileCheck --check-prefix=CHECK32 %s
// RUN: %clang -target powerpc-ibm-aix-xcoff -### -o dummy.so \
// RUN: %S/Inputs/aix_ppc_tree/dummy0.o -G 0 2>&1 | \
// RUN: FileCheck --check-prefix=CHECK32 %s
// RUN: %clang -target powerpc64-ibm-aix-xcoff -### -E -G 0 2>&1 %s | \
// RUN: FileCheck --check-prefix=CHECK64 %s
// RUN: %clang -target powerpc64-ibm-aix-xcoff -### -S -emit-llvm -G 0 2>&1 %s | \
// RUN: FileCheck --check-prefix=CHECK64 %s
// RUN: %clang -target powerpc64-ibm-aix-xcoff -### -c -G 0 2>&1 %s | \
// RUN: FileCheck --check-prefix=CHECK64 %s
// RUN: %clang -target powerpc64-ibm-aix-xcoff -### -c \
// RUN: %S/Inputs/aix_ppc_tree/dummy0.s -G 0 2>&1 | \
// RUN: FileCheck --check-prefix=CHECK64 %s
// RUN: %clang -target powerpc64-ibm-aix-xcoff -### -o dummy.so \
// RUN: %S/Inputs/aix_ppc_tree/dummy0.o -G 0 2>&1 | \
// RUN: FileCheck --check-prefix=CHECK64 %s
// CHECK32: error: unsupported option '-G' for target 'powerpc32-ibm-aix-xcoff'
// CHECK32: error: unsupported option '-G' for target 'powerpc-ibm-aix-xcoff'
// CHECK64: error: unsupported option '-G' for target 'powerpc64-ibm-aix-xcoff'