diff --git a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp index 73f661d7c049..76442fbda936 100644 --- a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp +++ b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp @@ -7088,26 +7088,25 @@ SDValue DAGCombiner::visitFREM(SDNode *N) { SDValue DAGCombiner::visitFSQRT(SDNode *N) { if (DAG.getTarget().Options.UnsafeFPMath) { - // Compute this as 1/(1/sqrt(X)): the reciprocal of the reciprocal sqrt. + // Compute this as X * (1/sqrt(X)) = X * (X ** -0.5) if (SDValue RV = BuildRsqrtEstimate(N->getOperand(0))) { AddToWorklist(RV.getNode()); - RV = BuildReciprocalEstimate(RV); - if (RV.getNode()) { - // Unfortunately, RV is now NaN if the input was exactly 0. - // Select out this case and force the answer to 0. - EVT VT = RV.getValueType(); - - SDValue Zero = DAG.getConstantFP(0.0, VT); - SDValue ZeroCmp = - DAG.getSetCC(SDLoc(N), TLI.getSetCCResultType(*DAG.getContext(), VT), - N->getOperand(0), Zero, ISD::SETEQ); - AddToWorklist(ZeroCmp.getNode()); - AddToWorklist(RV.getNode()); + EVT VT = RV.getValueType(); + RV = DAG.getNode(ISD::FMUL, SDLoc(N), VT, N->getOperand(0), RV); + AddToWorklist(RV.getNode()); - RV = DAG.getNode(VT.isVector() ? ISD::VSELECT : ISD::SELECT, - SDLoc(N), VT, ZeroCmp, Zero, RV); - return RV; - } + // Unfortunately, RV is now NaN if the input was exactly 0. + // Select out this case and force the answer to 0. + SDValue Zero = DAG.getConstantFP(0.0, VT); + SDValue ZeroCmp = + DAG.getSetCC(SDLoc(N), TLI.getSetCCResultType(*DAG.getContext(), VT), + N->getOperand(0), Zero, ISD::SETEQ); + AddToWorklist(ZeroCmp.getNode()); + AddToWorklist(RV.getNode()); + + RV = DAG.getNode(VT.isVector() ? ISD::VSELECT : ISD::SELECT, + SDLoc(N), VT, ZeroCmp, Zero, RV); + return RV; } } return SDValue(); diff --git a/llvm/test/CodeGen/PowerPC/recipest.ll b/llvm/test/CodeGen/PowerPC/recipest.ll index de74c043ecec..2f6a3eca4882 100644 --- a/llvm/test/CodeGen/PowerPC/recipest.ll +++ b/llvm/test/CodeGen/PowerPC/recipest.ll @@ -197,11 +197,7 @@ define double @foo3(double %a) nounwind { ; CHECK-NEXT: fmul ; CHECK-NEXT: fmadd ; CHECK-NEXT: fmul -; CHECK-NEXT: fre -; CHECK-NEXT: fnmsub -; CHECK-NEXT: fmadd -; CHECK-NEXT: fnmsub -; CHECK-NEXT: fmadd +; CHECK-NEXT: fmul ; CHECK: blr ; CHECK-SAFE: @foo3 @@ -220,9 +216,7 @@ define float @goo3(float %a) nounwind { ; CHECK: fmuls ; CHECK-NEXT: fmadds ; CHECK-NEXT: fmuls -; CHECK-NEXT: fres -; CHECK-NEXT: fnmsubs -; CHECK-NEXT: fmadds +; CHECK-NEXT: fmuls ; CHECK: blr ; CHECK-SAFE: @goo3 @@ -236,7 +230,6 @@ define <4 x float> @hoo3(<4 x float> %a) nounwind { ; CHECK: @hoo3 ; CHECK: vrsqrtefp -; CHECK-DAG: vrefp ; CHECK-DAG: vcmpeqfp ; CHECK-SAFE: @hoo3