maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Emit extern_weak when needed. 

- PR3629.

llvm-svn: 65203
This commit is contained in:
Daniel Dunbar 2009-02-21 00:24:10 +00:00
parent 0f35659b9a
commit 3c81dabd76
2 changed files with 32 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
clang/lib/CodeGen/CodeGenModule.cpp
View File

@ -264,7 +264,8 @@ void CodeGenModule::SetGlobalValueAttributes(const Decl *D,
} else
GV->setLinkage(llvm::Function::DLLImportLinkage);
}
}
} else if (D->getAttr<WeakAttr>())
GV->setLinkage(llvm::Function::ExternalWeakLinkage);
} else {
if (IsInternal) {
GV->setLinkage(llvm::Function::InternalLinkage);
@ -287,11 +288,10 @@ void CodeGenModule::SetGlobalValueAttributes(const Decl *D,
setGlobalVisibility(GV, attr->getVisibility());
// FIXME: else handle -fvisibility
if (const AsmLabelAttr *ALA = D->getAttr<AsmLabelAttr>()) {
// Prefaced with special LLVM marker to indicate that the name
// should not be munged.
// Prefaced with special LLVM marker to indicate that the name
// should not be munged.
if (const AsmLabelAttr *ALA = D->getAttr<AsmLabelAttr>())
GV->setName("\01" + ALA->getLabel());
}
if (const SectionAttr *SA = D->getAttr<SectionAttr>())
GV->setSection(SA->getName());
@ -598,8 +598,13 @@ void CodeGenModule::EmitGlobalDefinition(const ValueDecl *D) {
GV->setConstant(D->getType().isConstant(Context));
// FIXME: Merge with other attribute handling code.
if (D->getStorageClass() == VarDecl::PrivateExtern)
setGlobalVisibility(GV, VisibilityAttr::HiddenVisibility);
if (D->getAttr<WeakAttr>())
GV->setLinkage(llvm::GlobalValue::ExternalWeakLinkage);
}
// Make sure the result is of the correct type.

22
clang/test/CodeGen/global-decls.c Normal file
View File

@ -0,0 +1,22 @@
// RUN: clang -arch i386 -emit-llvm -o %t %s &&
// RUN: grep '@g0_ext = extern_weak global i32' %t &&
extern int g0_ext __attribute__((weak));
// RUN: grep 'declare extern_weak i32 @g1_ext()' %t &&
extern int __attribute__((weak)) g1_ext (void);
// RUN: grep '@g0_common = weak global i32' %t &&
int g0_common __attribute__((weak));
// RUN: grep '@g0_def = weak global i32' %t &&
int g0_def __attribute__((weak)) = 52;
// RUN: grep 'define weak i32 @g1_def()' %t &&
int __attribute__((weak)) g1_def (void) {}
// Force _ext references
void f0() {
int a = g0_ext;
int b = g1_ext();
}
// RUN: true