From 3c045070882f3f43135da6a40ef3f6508fe43af6 Mon Sep 17 00:00:00 2001 From: Jeremy Morse Date: Tue, 30 Nov 2021 12:41:59 +0000 Subject: [PATCH] [DebugInfo] Turn instruction referencing on by default for x86 This patch is designed to be reverted -- it activates a reasonably large block of new-ish code, so some turbulence is likely. Instruction referencing is best summarised, and it being on-by-default, is discussed here: https://lists.llvm.org/pipermail/llvm-dev/2021-November/153653.html Differential Revision: https://reviews.llvm.org/D114631 --- llvm/lib/CodeGen/CommandFlags.cpp | 2 ++ llvm/test/DebugInfo/X86/instr-ref-flag.ll | 4 ---- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/llvm/lib/CodeGen/CommandFlags.cpp b/llvm/lib/CodeGen/CommandFlags.cpp index ecf3d931fc33..3bed81d5841d 100644 --- a/llvm/lib/CodeGen/CommandFlags.cpp +++ b/llvm/lib/CodeGen/CommandFlags.cpp @@ -699,5 +699,7 @@ void codegen::setFunctionAttributes(StringRef CPU, StringRef Features, } bool codegen::getDefaultValueTrackingVariableLocations(const llvm::Triple &T) { + if (T.getArch() == llvm::Triple::x86_64) + return true; return false; } diff --git a/llvm/test/DebugInfo/X86/instr-ref-flag.ll b/llvm/test/DebugInfo/X86/instr-ref-flag.ll index b496bc418dec..f9d5f99edf77 100644 --- a/llvm/test/DebugInfo/X86/instr-ref-flag.ll +++ b/llvm/test/DebugInfo/X86/instr-ref-flag.ll @@ -13,10 +13,6 @@ ;; by llc by default, and that it can be turned explicitly on or off as ;; desired. -;; XFail it for pre-landing the patch, and to allow a minimal delta if it -;; has to be reverted. -; XFAIL: * - ; INSTRREFON: DBG_INSTR_REF ; INSTRREFOFF: DBG_VALUE